Repository navigation
Fix demo test cleanup on Node 25 - #25
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approved
The targeted change correctly removes the symlink itself while retaining rmSync for recursive test cleanup.
Pull request overview
Updates demo test cleanup for Node.js 25 compatibility.
Changes:
- Replaces
rmSyncwithunlinkSyncwhen removing the installed plugin symlink.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
File summaries
| File | Description |
|---|---|
tests/demo-run.test.js |
Removes the demo symlink using the appropriate filesystem API. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
unlinkSyncinstead ofrmSync.Why
Node 25 rejects
rmSyncwhen the path is a symlink to a directory. The test needs to remove the link itself before it puts a real directory in its place.unlinkSyncstates that operation directly and works on both Node 24 and Node 25.Tests
mise x node@24 -- ./tests/run./tests/runwith Node 25.1.0