Skip to content

Fix demo test cleanup on Node 25 - #25

Merged
robzolkos merged 1 commit into
masterfrom
fix/node-25-demo-symlink-cleanup
Sep 14, 2026
Merged

robzolkos merged 1 commit into
masterfrom
fix/node-25-demo-symlink-cleanup

Conversation

@robzolkos

Copy link
Copy Markdown
Collaborator

What changed

  • Remove the installed demo symlink with unlinkSync instead of rmSync.

Why

Node 25 rejects rmSync when the path is a symlink to a directory. The test needs to remove the link itself before it puts a real directory in its place. unlinkSync states that operation directly and works on both Node 24 and Node 25.

Tests

  • mise x node@24 -- ./tests/run
  • ./tests/run with Node 25.1.0

Copilot AI balanced review requested due to automatic review settings September 14, 2026 04:33

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

The targeted change correctly removes the symlink itself while retaining rmSync for recursive test cleanup.

Pull request overview

Updates demo test cleanup for Node.js 25 compatibility.

Changes:

  • Replaces rmSync with unlinkSync when removing the installed plugin symlink.

[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

File summaries
File Description
tests/demo-run.test.js Removes the demo symlink using the appropriate filesystem API.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@robzolkos
robzolkos merged commit 8d85cc7 into master Sep 14, 2026
5 checks passed
@robzolkos
robzolkos deleted the fix/node-25-demo-symlink-cleanup branch September 14, 2026 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants