Repository navigation
Preserve Bubble Up when opening threads - #26
Merged
Merged
Conversation
Retain HEY's bubbled-up posting state and skip the automatic mark-seen request when those threads are opened. Marking seen explicitly still pops the bubble.
Ignore repeated shutdown signals while cleanup is active and terminate the payload process group synchronously. This prevents TERM-ignoring descendants from surviving their wrapper.
There was a problem hiding this comment.
🟢 Approved
The implementation matches the reported behavior and includes focused regression coverage.
Pull request overview
Preserves HEY’s Bubbled Up state when opening threads while strengthening process cleanup.
Changes:
- Tracks
bubbled_upand avoids automatically marking bubbled threads as seen. - Adds regression coverage and updates user documentation.
- Handles repeated shutdown signals during bounded process cleanup.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
File summaries
| File | Description |
|---|---|
Service.qml |
Preserves bubbles when opening threads. |
Model.js |
Normalizes bubble state and hardens cleanup. |
tests/qml/tst_service.qml |
Tests bubbled-thread behavior. |
tests/model.test.js |
Tests repeated shutdown signals. |
tests/base-model.test.js |
Updates normalized model expectations. |
README.md |
Documents Bubbled Up behavior. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bubbled_upstate in panel notificationsTesting
./tests/runFixes #24