Skip to content

Preserve Bubble Up when opening threads - #26

Merged
robzolkos merged 2 commits into
masterfrom
fix/issue-24-preserve-bubble-up
Sep 14, 2026
Merged

robzolkos merged 2 commits into
masterfrom
fix/issue-24-preserve-bubble-up

Conversation

@robzolkos

Copy link
Copy Markdown
Collaborator

Summary

  • retain HEY's bubbled_up state in panel notifications
  • open bubbled-up threads without automatically marking them seen
  • keep explicit mark-as-seen available, which still pops the bubble
  • make bounded process cleanup resist repeated shutdown signals after the full test run exposed an existing flaky descendant cleanup

Testing

  • added the QML regression test first and confirmed it failed before the fix
  • ./tests/run
  • repeated the parent-death cleanup test 20 times

Fixes #24

Retain HEY's bubbled-up posting state and skip the automatic mark-seen request when those threads are opened. Marking seen explicitly still pops the bubble.
Ignore repeated shutdown signals while cleanup is active and terminate the payload process group synchronously. This prevents TERM-ignoring descendants from surviving their wrapper.
Copilot AI balanced review requested due to automatic review settings September 14, 2026 04:52

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approved

The implementation matches the reported behavior and includes focused regression coverage.

Pull request overview

Preserves HEY’s Bubbled Up state when opening threads while strengthening process cleanup.

Changes:

  • Tracks bubbled_up and avoids automatically marking bubbled threads as seen.
  • Adds regression coverage and updates user documentation.
  • Handles repeated shutdown signals during bounded process cleanup.

[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or run gh pr ready --undo.
Click "Ready for review" or run gh pr ready to reengage.

File summaries
File Description
Service.qml Preserves bubbles when opening threads.
Model.js Normalizes bubble state and hardens cleanup.
tests/qml/tst_service.qml Tests bubbled-thread behavior.
tests/model.test.js Tests repeated shutdown signals.
tests/base-model.test.js Updates normalized model expectations.
README.md Documents Bubbled Up behavior.
Review details
  • Files reviewed: 6/6 changed files
  • Comments generated: 0
  • Review effort level: Balanced

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@robzolkos
robzolkos merged commit 10d47d2 into master Sep 14, 2026
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bubbled Up threads are popped when opening them

2 participants