Repository navigation
Conversation
There was a problem hiding this comment.
🟡 Changes recommended
Fix the panel test assertion and preserve the existing root.foreground fallback.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds a setting to disable the urgent tray color for unread messages while preserving panel colors.
Changes:
- Adds the setting to the service, manifest, UI, and documentation.
- Updates tray icon color handling.
- Adds service and panel tests.
- Preserve the existing
root.foregroundfallback and update the panel test assertion.
File summaries
| File | Summary |
|---|---|
tests/qml/tst_service.qml |
Tests setting values and defaults. |
tests/panel.test.js |
Tests panel integration; assertion needs to match root.foreground. |
Service.qml |
Exposes the new setting. |
README.md |
Documents the setting. |
Panel.qml |
Adds the toggle and conditional tray coloring. |
manifest.json |
Registers the setting and default. |
Review details
Suppressed comments (1)
Panel.qml:436
- The non-urgent branch changed from the existing
root.foregroundtobutton.foreground.root.foregroundis the color used throughout this panel and provides the bar/local fallback; using a component property that is not declared or otherwise used here can make the icon's normal color undefined or change the default appearance. Keep the existing branch so the setting-off behavior remains unchanged.
color: !service.disableUrgentTrayColor && service.unreadCount > 0 ? root.urgent : root.foreground
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Lite (auto)
Note
Copilot is running an experiment and ran this review at Lite.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the HEY spirit of keeping email quiet (unless you decide otherwise), this PR adds a "Disable urgent tray color" setting.
The settings is OFF by default, showing the urgent color as it does today. Flipping the setting ON will keep the HEY icon the same (foreground) color at all times. (Urgent colors within the open panel are unchanged.)