Skip to content

Adds setting to disable urgent color for unread messages - #29

Open
rglanz wants to merge 2 commits into
basecamp:masterfrom
rglanz:rglanz/disable-urgent-color-setting
Open

rglanz wants to merge 2 commits into
basecamp:masterfrom
rglanz:rglanz/disable-urgent-color-setting

Conversation

@rglanz

@rglanz rglanz commented Sep 15, 2026

Copy link
Copy Markdown

In the HEY spirit of keeping email quiet (unless you decide otherwise), this PR adds a "Disable urgent tray color" setting.

The settings is OFF by default, showing the urgent color as it does today. Flipping the setting ON will keep the HEY icon the same (foreground) color at all times. (Urgent colors within the open panel are unchanged.)

screenshot-2026-09-15_12-57-45

Copilot AI balanced review requested due to automatic review settings September 15, 2026 18:03

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Fix the panel test assertion and preserve the existing root.foreground fallback.

Get a fresh assessment by requesting another Copilot review.

Pull request overview

Adds a setting to disable the urgent tray color for unread messages while preserving panel colors.

Changes:

  • Adds the setting to the service, manifest, UI, and documentation.
  • Updates tray icon color handling.
  • Adds service and panel tests.
  • Preserve the existing root.foreground fallback and update the panel test assertion.
File summaries
File Summary
tests/qml/tst_service.qml Tests setting values and defaults.
tests/panel.test.js Tests panel integration; assertion needs to match root.foreground.
Service.qml Exposes the new setting.
README.md Documents the setting.
Panel.qml Adds the toggle and conditional tray coloring.
manifest.json Registers the setting and default.
Review details

Suppressed comments (1)

Panel.qml:436

  • The non-urgent branch changed from the existing root.foreground to button.foreground. root.foreground is the color used throughout this panel and provides the bar/local fallback; using a component property that is not declared or otherwise used here can make the icon's normal color undefined or change the default appearance. Keep the existing branch so the setting-off behavior remains unchanged.
          color: !service.disableUrgentTrayColor && service.unreadCount > 0 ? root.urgent : root.foreground
  • Files reviewed: 6/6 changed files
  • Comments generated: 1
  • Review effort level: Lite (auto)

Note

Copilot is running an experiment and ran this review at Lite.


💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread tests/panel.test.js Resolved
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants