Repository navigation
Conversation
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
All-account search results cannot be opened reliably when the existing HEY TUI remains scoped to another account.
Get a fresh assessment by requesting another Copilot review.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Adds live HEY mail search with debouncing, cancellation, keyboard navigation, retry states, and demo support.
Changes:
- Adds a searchable third panel tab.
- Implements search commands, parsing, and result handling.
- Extends documentation, demo behavior, and automated tests.
| File | Description |
|---|---|
tests/qml/tst_search.qml |
Tests search lifecycle, races, and failures. |
tests/qml/imports/Quickshell/Io/Process.qml |
Supports deferred process exits in tests. |
tests/model.test.js |
Tests search commands and parsing. |
tests/demo.test.js |
Tests demo search behavior. |
Search.qml |
Implements debounced search and cancellation. |
README.md |
Documents search usage. |
Panel.qml |
Adds search UI, navigation, and result opening. |
Model.js |
Adds CLI routing and parsing; all-account results may open in a stale account-scoped TUI. |
demo/bin/hey |
Adds demo search support. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Author
|
The account-routing fix is pushed in 3d75122. Could a maintainer request a fresh Copilot review? GitHub denied my re-review request because I do not have permission to request reviews in this repository. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

I realize search may go beyond the intended scope of this widget. For me, it was the missing piece, so I wanted to offer it as a PR. Feel free to use, adapt, or pass on it as you see fit.
What changes
Search…input./to enter Search.Search runs per panel and cancels obsolete requests, with a revision check to discard late responses. It reuses the existing themed controls, email rows, CLI output limits, and timeout handling. The demo CLI supports search too.
Verification
./tests/run: 90 Node tests and 100 QtTest checks passed, including the existing coverage gates.Account routing
All-account search queries each linked account separately and retains its numeric account ID on every result. The TUI receives that numeric ID when opening a result, so an existing instance can switch to the matching account using the released CLI's remote-open protocol. Requests run sequentially through the existing bounded process, and results are published after every account succeeds.