Repository navigation
Conversation
The org is moving to require SHA-pinned actions. Each tag or branch reference now names the commit it points to today, so behavior is unchanged. Dependabot's github-actions updates keep the pins current.
There was a problem hiding this comment.
🟢 Approved
No active review issues are reported for the action-pinning and Dependabot configuration changes.
No open issues 🎉
What changed in this PR
Prepares the test workflow for the organization’s full-commit-SHA requirement and adds automated maintenance for action pins.
Changes:
- Pins
actions/checkoutandactions/setup-nodeto full commit SHAs, with release-version comments. - Adds weekly, grouped Dependabot updates for GitHub Actions.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
.github/workflows/tests.yml |
Replaces two action tags with full commit SHAs. |
.github/dependabot.yml |
Configures weekly, grouped GitHub Actions updates. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The basecamp org is about to allow only listed actions and to require every action to be pinned to a full commit SHA. Once that's on, a step that names an action by tag or branch (
actions/checkout@v4) won't start. This pins the 2 such references in this repo ahead of the switch.Behavior-neutral. Each reference now names the commit its tag or branch points to today, so the same action code runs. The trailing comment names the release at that commit (
@v4becomes@<sha> # v4.x.y), which is what Dependabot reads to bump it.Keeping the pins current. Adds
.github/dependabot.ymlwith a weekly, groupedgithub-actionsupdate, so the SHAs get bumped in one PR a week instead of going stale.Local actions (
./) and reusable workflows aren't covered by the SHA rule and are left as they were.Pinned with pinact. Each SHA was checked against the action's own repo: it exists there, and it is the commit the replaced tag or branch, and the release in the comment, point to today.