Repository navigation
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟡 Changes recommended
Numeric zero cache overrides are passed correctly to Docker but recorded as enabled in bench/compare.rb, causing the reported topology to misrepresent the benchmarked configuration.
1 open issue
What changed in this PR
Adds Egg as an optional implementation in the shared Campfire verification and benchmark harness, without changing the default app list.
Changes:
- Allows selecting Egg with
--apps egg. - Records Egg’s HTTP workers, cable event loops, and cache configuration.
- Documents
EGG_IMAGEand how to benchmark Egg with caching disabled.
[!TIP]
If you aren't ready for review, convert to a draft PR.
Click "Convert to draft" or rungh pr ready --undo.
Click "Ready for review" or rungh pr readyto reengage.
| File | Description |
|---|---|
| README.md | Documents optional Egg selection, image overrides, and cache controls. |
| bench/compare.rb | Allows Egg and adds implementation-specific topology metadata. |
Review effort: Balanced
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

This adds once-campfire-egg, a port of Campfire to Egg, as an optional
eggapp. Select it with--apps eggandEGG_IMAGE(defaultonce-campfire-egg:app; source checkout../once-campfire-egg). It is not in the default app list.The change:
eggin the allowed apps;CAMPFIRE_WORKERS), cable event loops (CAMPFIRE_CABLE_LOOPS) and its cache, which is on by default;EGG_BENCH_ENV='{"CAMPFIRE_CACHE":"0"}'measures it uncached;bin/checkpasses. A run with--apps rust,eggpasses againstmainof once-campfire-egg (e152b5b), andbin/browserpasses on a fresh database.Why an Egg port
Egg is a small language with ownership instead of a garbage collector, compiled to C. We wanted a real application to find where it hurts, and numbers to compare with the other ports. Agents wrote it, with the Rust port as the reference: pages match once-campfire-rust's byte for byte. It uses the same SQLite database, storage layout, signed cookies, signed ids and Turbo stream names as Rails. C libraries (SQLite, zlib-ng, libcrypto, libcurl) are called through Egg's
extern fn.Run on our host
Intel i7-9700K, OrbStack Linux VM with 8 vCPUs; app on CPUs 0-3, load generator on CPUs 4-7; 3 alternating rounds, 16 clients. Against Rust
6dae2fd(the published image, with its caches):All responses were valid, and the write audit verified every acknowledged post. Rust's posts varied the most between runs on this host (1,450–1,980 the same day); Egg's were 2,350–2,490. The absolute numbers are lower than in your published table because of the host.
With
loadgen cable, 1,000 clients on one busy room, every message reached every client for both: 209 messages/s to all clients at full load for Egg, 186 for Rust; 47 MiB peak memory against 136.What the harness found
VAPID_PUBLIC_KEYstopped our app from starting: we compared it as text with our own unpadded encoding. It is fixed onmain.main: every broadcast woke every cable event loop, even with no socket listening; push notifications were built inside the message's transaction; and the commit that crossed 1,000 WAL pages ran the checkpoint while holding the write lock. Checkpoints now run on their own thread, as in your Rust port.Thank you for the strict contracts and the write audit.
Notes
Known gaps
data_version), so a write empties every worker's cache.