カスタムコンテンツ草稿プレビュー機能実装#4191
Merged
Merged
Conversation
This reverts commit 01016b5.
# Conflicts: # plugins/bc-custom-content/src/Controller/CustomContentController.php # plugins/bc-custom-content/src/Service/CustomEntriesService.php
ryuring
reviewed
May 12, 2025
| const previewUrl = $.bcUtil.adminBaseUrl + 'baser-core/preview/view?url=' + customEntriesForm.fullUrl + '&preview=default'; | ||
|
|
||
| var previewMode = '&preview=default'; | ||
| if ($("#ContentPreviewMode").val() == 'draft') { |
| continue; | ||
| } | ||
| $name = $customField->name; | ||
| $entity->$name = $entity->detail_draft; |
Collaborator
There was a problem hiding this comment.
detail_draft と名前が決め打ちになってしまっているのが気になります
草稿フィールドの取得メソッドをプラグイン側に作る方針を考えたいですね
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@ryuring
草稿プレビュー機能を実装しました！
ご確認よろしくお願いします！