fix #4176 【フィード 】index.rssがErrorになる問題を解決#4196
Merged
Merged
Conversation
Collaborator
Author
|
@ryuring |
ryuring
reviewed
May 21, 2025
| * @unitTest | ||
| */ | ||
| public function getViewVarsForIndexRss(ServerRequest $request, BlogContent $blogContent, ResultSet $posts): array | ||
| public function getViewVarsForIndexRss(ServerRequest $request, BlogContent $blogContent, PaginatedResultSet|ResultSet $posts): array |
Collaborator
There was a problem hiding this comment.
@katokaisya ここは、PaginatedResultSet 固定でお願いします。テストの方を修正してください。
added 4 commits
May 21, 2025 19:48
Collaborator
|
@katokaisya テストの失敗対策はこちらを参考にしてください。一度解決してましたので。 |
Collaborator
|
@katokaisya 本日のリリースに含めたかったので僕の方で修正しました。 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
こちら一旦テストを通してみます