fix #4428 【システム】サブフォルダに設置するとプレビューがエラーになる件を修正#4430
Open
kaburk wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
本PRは、baserCMS をサブフォルダ配下(例: /sub)に設置している場合に、管理画面のプレビューURL解決が失敗してエラーになる問題(#4428)を修正し、あわせて回帰テストを追加するものです。
Changes:
- プレビューURL生成処理で、リクエストの
base(サブフォルダ)を考慮してURLパスを補正するロジックを追加 - サブフォルダ運用時のトップページプレビュー解決のテストを追加
- サブフォルダ運用時のブログ記事URLが
BcBlogのルーティングに解決されるテストを追加
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| plugins/baser-core/src/Controller/Admin/PreviewController.php | base 属性を考慮してプレビュー対象URLのパスを補正し、ルーティング解決を安定化 |
| plugins/baser-core/tests/TestCase/Controller/Admin/PreviewControllerTest.php | サブフォルダ運用時のプレビューURL解決(固定ページ/ブログ)に関する回帰テストを追加 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
フォーラムからの不具合の件の修正です。
よろしくお願いします。