Skip to content

admin-ui: stop logging raw AxiosError (api-token) on list/delete failures #96

Closed

Description

@bashrusakh

Context

Follow-up from the #95 review (non-blocking P2), not a regression of that PR. The preset-save failure path added in #95 logs only a bounded message; this issue covers older admin-ui call sites that still log a raw AxiosError.

Verified facts

admin-ui/src/utils/request.js:68-70 adds the auth token to every request config:

const token = userStore.token || getToken()
if (token) {
  config.headers['api-token'] = token
}

On an HTTP/transport failure axios rejects with an AxiosError that carries config (including that header). These catches log the whole error object:

  • admin-ui/src/views/custom-client/index.vue:1501 — loadPresets() catch (custom_preset/list)
  • admin-ui/src/views/custom-client/index.vue:1428 — loadBuilds() catch (custom_build/list)
  • admin-ui/src/views/custom-client/index.vue:1628 — deleteBuild() catch (custom_build/delete)
  • admin-ui/src/views/custom-client/index.vue:1701 — deletePreset() catch (custom_preset/delete)

The response interceptor already toasts a bounded message for these failures, so the raw console log adds no required signal and exposes the token (and potentially request data) in devtools or support screenshots.

Expected behavior

Failed list/delete requests must not log the raw AxiosError/config. Log only a bounded diagnostic (for example e?.message || String(e), consistent with reportCreateBuildFailure at index.vue:1116) or drop the log where the interceptor already surfaced the failure.

Acceptance

  • A failing custom_preset/list, custom_build/list, custom_preset/delete, or custom_build/delete request does not print config.headers['api-token'] or request bodies to the console.
  • A bounded diagnostic remains for genuinely unexpected failures (or the failure is already fully surfaced by the interceptor).
  • No change to user-visible behavior, API contracts, or the admin-ui: surface preset save field errors inline #95 preset-save path.
  • If practical, a regression test asserts that the raw config/headers are not passed to console.error.

Scope and constraints

Activity

  1. added a commit that references this issue on Oct 21, 2026
    1880c76
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't working

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions