ci(release): create the release object before asset uploads#20
Merged
Conversation
Both release jobs upload assets via `gh release upload`, which requires the release object to already exist for the tag - neither job created it, so a fresh tag push failed with "release not found" on both platforms. Adds a create-release job (idempotent: `gh release view` first, so re-runs after a transient failure don't error on an already-created release) and gates both build jobs on it via `needs: create-release`, matching the fixed suite-wide pattern already on basilica-audio/crypta main. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The tag-triggered release workflow was missing the release-creation step: both
release-macosandrelease-windowsupload assets viagh release upload, which requires the release object to already exist for the tag — neither job created it, so a fresh tag push failed with "release not found" on both platforms (suite-wide issue discovered tonight).This copies the fixed pattern already on
basilica-audio/cryptamain, changing nothing else:create-releasejob (ubuntu-latest), idempotent:gh release view "$GITHUB_REF_NAME" || gh release create "$GITHUB_REF_NAME" --title "$GITHUB_REF_NAME" --generate-notes— re-runs after a transient build failure don't error on an already-created release.needs: create-releaseon both existing build jobs.Tag-triggered workflows run the workflow file as of the tagged commit, so this must be on
mainbeforev0.2.0is tagged — which is why it's a separate PR after #19 rather than part of it.Test plan
.github/workflows/release.yml(+22 lines, no other changes)basilica-audio/cryptamain (create-releasejob +needs:on both build jobs at lines 43/142)v0.2.0tag push after this merges🤖 Generated with Claude Code