ci(release): add tag-triggered signed release workflow#10
Merged
Conversation
Mirrors the suite-wide template (.scaffold/release-workflow-template.yml) with the CMake target substituted for Seraph. Locates build artefacts via find rather than a hardcoded Release/ path, matching ci.yml's existing "Locate plugin artefacts" workaround for single- vs multi-config generators.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.github/workflows/release.yml, adapted from the suite-wide template (.scaffold/release-workflow-template.yml) with the CMake target substituted forSeraph(confirmed viaproject(Seraph ...)/juce_add_plugin(Seraph ...)inCMakeLists.txt, matchingci.yml'sbuild/Seraph_artefactsartefact root).push: tags: ['v*']only — never runs on pull requests (including from forks), so org secrets are never exposed to untrusted code.if: always()step), codesigns, notarizes vianotarytool, staples, zips, and uploads to the GitHub release.findagainstbuild/Seraph_artefactsinstead of a hardcoded.../Releasepath, mirroringci.yml's existing "Locate plugin artefacts" step, since JUCE's output path depends on whether the generator is single- or multi-config.contents: writeonly (needed to attach release assets).Status / dependencies
APPLE_CERT_P12,APPLE_CERT_PASSWORD,APPLE_API_KEY_P8,APPLE_API_KEY_ID,APPLE_API_ISSUER_ID) that are not part of this PR. Until those are configured at the org level, av*tag push will fail at the signing step..github/were modified — this PR only adds the new workflow file.Test plan
python3 -c "import yaml; yaml.safe_load(open('.github/workflows/release.yml'))"— YAML parses cleanly.v*tag once org secrets are configured, and confirm the release workflow runs end-to-end (out of scope for this PR — human-supervised follow-up).🤖 Generated with Claude Code