Fix release workflow: create the release object before asset upload#21
Merged
Conversation
Both release-macos and release-windows upload assets via `gh release upload`, which requires the release object to already exist for the tag - neither job created it, so both failed with "release not found" on a fresh tag push. Add an idempotent create-release job (gh release view || gh release create) and make both build jobs depend on it. Mirrors the fix already merged in basilica-audio/crypta.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
create-releasejob (gh release view || gh release create --generate-notes) so the release object exists before either build job runsgh release upload- without it, both jobs fail with "release not found" on a fresh tag push.release-macosandrelease-windowsdepend on it (needs: create-release).Test plan