Skip to content

fix(deps): move brace-expansion and fast-uri to patched versions in the lockfile - #309

Merged
takashi-matsuyama merged 1 commit into
mainfrom
fix/dev-tree-alerts-lockfile
Oct 4, 2026
Merged

takashi-matsuyama merged 1 commit into
mainfrom
fix/dev-tree-alerts-lockfile

Conversation

@takashi-matsuyama

Copy link
Copy Markdown
Member

Moves brace-expansion and fast-uri to patched versions. Lockfile only: every package moves inside its existing range, so no manifest changes.

Alert Advisory Package Change
#33 GHSA-q2hr-2g5m-vwhr (medium) brace-expansion 2.1.4 -> 2.1.7
#32 GHSA-q2hr-2g5m-vwhr (medium) brace-expansion 5.0.9 -> 5.0.12
#34 GHSA-hrr3-gc8f-f4qj (medium) fast-uri 3.1.7 -> 3.1.8

The same two bumps also close four high advisories that Dependabot had auto-dismissed rather than left open: GHSA-qhr7-859c-m2p7 (#31, #30) and GHSA-6j4f-fj2g-mc7p (#29, #28), both on brace-expansion.

That is the whole diff: 12 lines each way.

The published packages are not affected

Dependabot labels the fast-uri alert runtime, which is wrong here, as it was in #204. Its only path into the tree is packages/core's devDependencies (ajv / ajv-formats, used by the schema tests). pnpm why fast-uri -r --prod finds nothing. The published packages' production dependencies reach neither package:

$ npm view @basou/core@0.64.0 dependencies
{ zod: '^4.6.5', ulid: '^3.0.2', yaml: '^2.9.1', 'simple-git': '^3.36.0' }
$ npm view @basou/cli@0.64.0 dependencies
{ commander: '^14.0.3', '@basou/core': '0.64.0' }
$ npm view @basou/sdk@0.64.0 dependencies
{ '@basou/core': '0.64.0' }

What stays open

pnpm audit (dev included) still reports three advisories, all dev-only:

The CI audit gate (pnpm audit --audit-level=moderate --prod) covers production dependencies only, by design. This PR leaves that scope unchanged.

Verification

Run on a copy of this branch:

  • pnpm install --frozen-lockfile, pnpm -r build, pnpm typecheck, pnpm -r test:coverage, pnpm test:scripts, pnpm lint, pnpm lint:lang, pnpm lint:paths and pnpm audit --audit-level=moderate --prod all exit 0. Test counts: core 2205 passed and 1 skipped, sdk 65, cli 1379.
  • Full pnpm audit: before, it reported ten advisories, seven of them on brace-expansion and fast-uri. After, the three listed above remain.

Checklist

🤖 Generated with Claude Code

…he lockfile

Lockfile only: every package moves inside its existing range, so no
manifest changes.

- brace-expansion 2.1.4 -> 2.1.7 and 5.0.9 -> 5.0.12 (GHSA-q2hr-2g5m-vwhr,
  plus GHSA-qhr7-859c-m2p7 and GHSA-6j4f-fj2g-mc7p, which Dependabot
  auto-dismissed)
- fast-uri 3.1.7 -> 3.1.8 (GHSA-hrr3-gc8f-f4qj)

All are dev-only: fast-uri reaches the tree only through packages/core's
devDependencies (ajv / ajv-formats), and none of the published packages'
production dependencies reach either package.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@takashi-matsuyama
takashi-matsuyama merged commit 6b35287 into main Oct 4, 2026
8 checks passed
@takashi-matsuyama
takashi-matsuyama deleted the fix/dev-tree-alerts-lockfile branch October 4, 2026 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant