Repository navigation
basou: Let a registered component on a board name the files that mark it - #366
Merged
Merged
Conversation
A directory no built-in marker finds, such as one of content or of scripts, was gone at every measure and fired the axis review's (a) each time. From board_version 3, components.<key>.marker is a glob from the component's directory, written and checked as an include is. When a file the working tree lists under that directory matches it, the component is found with the kind marker; when none does, it is gone, as before. A key that is a repo itself takes no marker. A board of version 1 or 2 with a marker is told that version 3 reads it. The components method stays 2: a registry without a marker measures as before. The guide and the comment board init writes say when to give a component a marker.
…d pin how a marker key is read A registered key whose path holds a lone surrogate named no directory, yet its bytes read as U+FFFD, so a marker found it under a directory of that name: it is now gone. An empty key with a marker is told only that it is empty, not also that it is a repo itself. Tests now pin that a key's path is read as written (not as a glob, not normalized, so 'app//x' and a trailing '/' find nothing and are not refused), that a name that is not valid UTF-8 is matched as its bytes are, that a repo itself takes no marker whatever the marker is, and the order of the problems with one component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A directory no built-in marker finds, such as one of content or of scripts, could be registered under a board's
components, but it was thengoneat every measure and fired the axis review's (a) each time. Fromboard_version: 3, a registered component can name the files that mark it.components.<key>.markeris a glob from the component's directory, in the dialect of aninclude(*does not cross/), and is checked as anincludeis: an absolute path, a..segment, a leading:and a control character are refused (the message says it must be relative to the component's directory).markeramong its kinds (beside any kind a built-in marker finds there). When none does, it isgone, as before. The directories the built-in markers skip (such asnode_modules) are not skipped for a marker./, or nothing after the first/) takes no marker: the declaration is refused. A key's path is read as written, neither as a glob nor normalized, so a key that names a file, one git would not write (app//x, a trailing/) and one that is not well-formed text find nothing.componentsmethod stays 2: a registry without a marker measures as before. A component the built-in markers already found hasmarkeradded to its kinds once it is given one, which the next measure reports as a change of kinds.basou board guidesays when to give a gone component a marker (and not only to silence (a)), and the commentbasou board initwrites abovecomponentssays so too. The record version comment and CHANGELOG (Unreleased) say what came in.This is part of the board's version 3 and targets the integration branch
board/shape-v3; nothing is released from it.Checks
pnpm -r build,pnpm typecheck,pnpm -r test:coverage(core 2908 passed and 1 skipped, sdk 67, cli 1564),pnpm test:scripts,pnpm lint,pnpm lint:lang,pnpm lint:paths: all exit 0.