chore(renovate): document every rule, drop the inert digest gate - #1174
Merged
Conversation
The config had grown to seven packageRules with a single description between them, so there was no way to tell which rules were load-bearing and which were fossils. Rules nobody dares delete are how a config only ever grows. Add a top-level description stating the policy (weekly batches, automerge on green, majors gated on the dashboard, 7-day release age, digest pinning), and a description on every rule. Some genuinely read as mistakes without one: "enabled": true on the indirect rule looks like a no-op but is required, and the majors rule carrying both automerge and dependencyDashboardApproval looks contradictory until you know that ticking the box is the approval. Drop the gomod digest rule. It used a nested updateType object that never took effect (the x/exp digest branch was created without ever appearing under Pending Approval) and it contradicted the automerge rule above it. Pseudo-version bumps now ride the same test matrix and 7-day gate as everything else. No other behaviour change: the diff is descriptions plus that deletion. Validated with renovate-config-validator v44.39 (the hosted app) and v40.62.1 (the version pinned in .pre-commit-config.yaml). Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The config had grown to seven
packageRuleswith a singledescriptionbetween them. That's the real maintenance cost of a config like this — not its length, but that nobody can tell which rules are load-bearing and which are fossils, so nothing ever gets deleted.Added a top-level
descriptionstating the policy in five lines (weekly batches, automerge on green, majors gated on the dashboard #10, 7-day release age, digest pinning), plus adescriptionon every rule. Three of them genuinely read as mistakes without one:"enabled": trueon the indirect rule looks like a no-op — Renovate skips indirect Go deps unless told otherwise, so it's required.automergeanddependencyDashboardApproval, which looks contradictory until you know that ticking the dashboard box is the approval.Removed the gomod digest rule:
{ "matchManagers": ["gomod"], "digest": { "dependencyDashboardApproval": true } }It used a nested update-type object that never took effect — the
golang.org/x/expdigest branch was created without the update ever appearing under Pending Approval on #10 — and it contradicted the automerge rule above it. Pseudo-version bumps now ride the same test matrix and 7-day age gate as every other dep.No other behaviour change. The diff is description strings plus that one deletion. Validated with
renovate-config-validatorv44.39 (the hosted app's version) and v40.62.1 (the version pinned in.pre-commit-config.yaml).🤖 Generated with Claude Code