Fix script to use pip's python version#10
Open
DanLipsitt wants to merge 1 commit intobaverman:masterfrom
Open
Conversation
Problem ------- On systems where `python` points to `python2` but `pip` points to `pip3`, `bin/flameprof` breaks because it runs python2 but the flameprof library is installed into python2's `site-packages`. Fix --- Instead of using `scripts` in `setup.py`, use the `console_scripts` entry point (https://python-packaging.readthedocs.io/en/latest/command-line-scripts.html). This will automatically create and install a `flameprof` script that works with python 2 or 3 (whichever pip is working with). In order to facilitate this, I created a `main` function in `flameprof.py`.
|
Would be great if this could be merged and a new release made. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On systems where
pythonpoints topython2butpippoints topip3,bin/flameprofbreaks because it runs python2 but the flameprof library is installed into python2'ssite-packages.Fix
Instead of using
scriptsinsetup.py, use theconsole_scriptsentry point (https://python-packaging.readthedocs.io/en/latest/command-line-scripts.html). This will automatically create and install aflameprofscript that works with python 2 or 3 (whichever pip is working with).In order to facilitate this, I created a
mainfunction inflameprof.py.