perf: avoid temp sort key arrays in sortStringExprs - #1487
Open
jbedard wants to merge 1 commit into
Open
Conversation
jayconrod
pushed a commit
to bazel-contrib/bazel-gazelle
that referenced
this pull request
Aug 18, 2026
**What type of PR is this?** Perf - memory reduction. **What package or component does this PR mostly affect?** all **What does this PR do? Why is it needed?** Same as bazel-contrib/buildtools#1487 where this code was vendored from. **Which issues(s) does this PR fix?** Fixes # **Other notes for review**
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buildtools PR checklist
Description
Sorting is now allocation-free apart from boxing the chunk into a
sort.Interface(a TODO notes theslices.SortStableFuncreplacement once the go directive reaches 1.21).Added unit tests for odd edge cases to ensure they do not change.