[8.8.0] 01/23: Refactoring from: Make external repo file checking actually useful#29067
Draft
fmeum wants to merge 1 commit into
Draft
[8.8.0] 01/23: Refactoring from: Make external repo file checking actually useful#29067fmeum wants to merge 1 commit into
fmeum wants to merge 1 commit into
Conversation
…seful Non-functional changes only: remove Pair indirection in ExternalFilesHelper, extract getExternalRepoName() and getExternalDirectory() helpers, move addExternalFilesDependencies into ExternalFilesHelper, modernize switch expression in DirtinessCheckerUtils, formatting fixes. Does not include the functional behavior change of refetching repos on external modifications. (cherry picked from commit 5e3f0c8)
Member
|
@fmeum Are all these PR's from 1/23 to 23/23 soft release blockers? |
Collaborator
Author
|
I'll send them for review one by one and see what gets in, you don't have to track the progress. |
iancha1992
added
the
soft-release-blocker
iancha1992
changed the title
|
Thank you for contributing to the Bazel repository! This pull request has been marked as stale since it has not had any activity in the last 30 days. It will be closed in the next 30 days unless any other activity occurs. If you think this PR is still relevant and should stay open, please post any comment here and the PR will no longer be marked as stale. |
github-actions
Bot
added
the
stale
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of 5e3f0c8 for release 8.7.0 (part 01/23 of the remote repo contents cache feature).
Non-functional changes only: remove Pair indirection in ExternalFilesHelper, extract
getExternalRepoName()andgetExternalDirectory()helpers, moveaddExternalFilesDependenciesinto ExternalFilesHelper, modernize switch expression in DirtinessCheckerUtils, formatting fixes.Does not include the functional behavior change of refetching repos on external modifications.