[8.7.0] Fix crash when repo contents cache is under the main repo#29070
Merged
Conversation
fmeum
changed the title
fmeum
changed the title
fmeum
changed the title
We try to release the shared lock in `afterCommand`, but that crashes if we never acquired the shared lock in `beforeCommand` because the repo content cache is under the main repo. Also fix wording to be more accurate (s/workspace/main repo) PiperOrigin-RevId: 765087159 Change-Id: Iee2e6f25e361fcd67c8231b7fb1f99db7336027b (cherry picked from commit 7b792b6)
github-actions
Bot
added
the
awaiting-review
iancha1992
added
the
team-Remote-Exec
meteorcloudy
approved these changes
Apr 7, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-actions
Bot
removed
the
awaiting-review
Collaborator
Author
|
@meteorcloudy Friendly ping |
Collaborator
Author
|
Whoops, didn't refresh, please ignore the ping. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We try to release the shared lock in
afterCommand, but that crashes if we never acquired the shared lock inbeforeCommandbecause the repo content cache is under the main repo.Also fix wording to be more accurate (s/workspace/main repo)
PiperOrigin-RevId: 765087159
Change-Id: Iee2e6f25e361fcd67c8231b7fb1f99db7336027b
(cherry picked from commit 7b792b6)