[8.7.0] Fold environ into the predeclared inputs hash #29072
Merged
Conversation
This makes repo contents cache lookups more efficient and avoids later Skyframe restarts. Along the way, switch more `RepoRecordedInputs`-related fields to `ImmutableSortedMap`. This type has a lower memory usage than `ImmutableMap` and guarantees canonical ordering of entries. Closes bazelbuild#26768. PiperOrigin-RevId: 797852193 Change-Id: Icf1b7291fec3e01048c365f86446b139c281bde9 (cherry picked from commit fe040a3)
fmeum
changed the title
environ into the predeclared inputs hashenviron into the predeclared inputs hash
github-actions
Bot
added
team-ExternalDeps
meteorcloudy
approved these changes
Apr 1, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
github-actions
Bot
removed
the
awaiting-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes repo contents cache lookups more efficient and avoids later Skyframe restarts.
Along the way, switch more
RepoRecordedInputs-related fields toImmutableSortedMap. This type has a lower memory usage thanImmutableMapand guarantees canonical ordering of entries.Closes #26768.
PiperOrigin-RevId: 797852193
Change-Id: Icf1b7291fec3e01048c365f86446b139c281bde9
(cherry picked from commit fe040a3)