[8.7.0] Reproduce a Skyframe cycle with the repo contents cache in a test#29076
Merged
Conversation
fmeum
changed the title
…test This documents an issue with the current implementation, not the intended behavior. Also improve the cycle detector to actually show the cycle in this case. Work towards bazelbuild#27517 Closes bazelbuild#27419. PiperOrigin-RevId: 829118042 Change-Id: Iaafda95216ac8afd9cd93f5a91b17a27e3611d63 (cherry picked from commit 0336a86)
github-actions
Bot
added
team-ExternalDeps
meteorcloudy
approved these changes
Apr 10, 2026
Merged
via the queue into
bazelbuild:release-8.7.0
with commit Apr 10, 2026
49767fb
47 checks passed
github-actions
Bot
removed
the
awaiting-review
Ari4ka
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This documents an issue with the current implementation, not the intended behavior.
Also improve the cycle detector to actually show the cycle in this case.not included in the cherry-pickWork towards #27517
Closes #27419.
PiperOrigin-RevId: 829118042
Change-Id: Iaafda95216ac8afd9cd93f5a91b17a27e3611d63
(cherry picked from commit 0336a86)