Gate external-repo source dir package boundary checks behind a flag#30019
Closed
fmeum wants to merge 2 commits into
Closed
Gate external-repo source dir package boundary checks behind a flag#30019fmeum wants to merge 2 commits into
fmeum wants to merge 2 commits into
Conversation
Besides fixing the false positives reported in bazelbuild#29688, this also started enforcing a genuinely new class of errors: a source directory in an external repository that crosses a package boundary into a sub-package of that same external repository. Previously the lookup always resolved against the main repository, so such crossings inside external repositories went undetected and the build succeeded. That is an incompatible change: builds that worked on 9.1.1 now fail (see the repro in bazelbuild#29688). Gate the new enforcement behind --incompatible_check_external_repo_source_dir_package_boundary (default off). When the flag is off, package boundary crossings by source directories in external repositories are skipped entirely rather than reverting to the old main-repo lookup, so bazelbuild#29688 stays fixed regardless of the flag value; only the new strictness is deferred. Source directories in the main repository are unaffected.
fmeum
force-pushed
the
incompatible-check-external-repo-source-dir-package-boundary
branch
from
5cd39dd to
1d3f3d3
Compare
github-actions
Bot
added
team-Core
Collaborator
Author
|
@bazel-io fork 9.2.0 |
Wyverald
reviewed
Jun 26, 2026
| effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS}, | ||
| metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE}, | ||
| help = | ||
| "If true, a source directory in an external repository fails the build if it crosses a" |
Member
There was a problem hiding this comment.
just a quick comment: is "source directory" the well-known name for this concept? This sentence is very confusing to me without reading the integration set up in SourceDirectoryIntegrationTest.java ("how can a directory cross package boundaries?").
Collaborator
Author
There was a problem hiding this comment.
Yes, the rollout flag was named "track source directories" and this has been the term used for them (unfortunately we say tree artifact instead of generated directory...)
Collaborator
Author
There was a problem hiding this comment.
The source directory / package interaction is legitimately confusing. Happy to reword it you think that this should be clarified, I'm just not sure how.
Member
There was a problem hiding this comment.
ok, thanks for the context. I don't have a much better idea either to be honest, so let's keep it as is for now.
…ectoryIntegrationTest.java Co-authored-by: Xùdōng Yáng <wyverald@gmail.com>
github-actions
Bot
removed
the
awaiting-review
2 tasks
fmeum
deleted the
incompatible-check-external-repo-source-dir-package-boundary
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
#29692 made the package-boundary check for source directories in
RecursiveFilesystemTraversalFunctionrepo-aware. Besides fixing the false positives reported in #29688, it also made the check effective for source directories in external repos, which is a breaking change.This PR gates that new enforcement behind
--incompatible_check_external_repo_source_dir_package_boundary(default off).When the flag is off, package boundary crossings by source directories in external repositories are skipped entirely rather than reverting to the old main-repo lookup. As a result, #29688 stays fixed regardless of the flag value.
Motivation
#29688 (comment)
Build API Changes
Yes: adds the command-line flag
--incompatible_check_external_repo_source_dir_package_boundary.Checklist
Release Notes
RELNOTES: Source directories in external repositories are temporarily allowed to cross package boundaries. This will be disallowed in the future, gated by the new
--incompatible_check_external_repo_source_dir_package_boundaryflag.