fix(test): make //distro:packaging_test work with Bazel 9
#1009
+37
−17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bazel 9 flipped
--incompatible_strict_action_envtotrueby default (bazelbuild/bazel#27670), which means tests no longer inheritPATHfrom the host environment. This breaks subprocess calls that rely onPATHlookup:This change therefore adds
env_inherit = ["PATH"]to that very test, which matches the behavior of earlier Bazel versions and is consistent with the presence of a"noci"tag.Additionally, Bazel 9 removed
WORKSPACEsupport entirely (bazelbuild/bazel#26131), requiringbzlmodwithMODULE.bazel:The test now detects the Bazel version at runtime and generates the appropriate setup:
MODULE.bazel, withbazel_depandarchive_override,WORKSPACE, withhttp_archiveand--enable_workspaceflag.For good measure, the change also addresses a leftover TODO by replacing the
tarsubprocess invocation with pure Python code (as otherwise done in the repo).