Open
Conversation
* Fix build by invoking gfortran directly Relatively ugly hack to allow downstream packages to use the library * Clean up the build process
Fix pylint errors throughout
Contributor
Author
This was incorrect, and has now been fixed by reverting to the original code |
bbalasub1
reviewed
Apr 10, 2020
Owner
bbalasub1
left a comment
bbalasub1
left a comment
There was a problem hiding this comment.
Where did you get this setup.py from? It does not seem to be available in the main branch.
Contributor
Author
|
This was one I modified to get it to work with |
|
This PR would likely resolve #64 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please consider this pull request to your repository. The fork is the version currently installable via conda-forge. I have made the following changes, mostly by running
pylintand fixing errors:scipyarray functions tonumpy. Thescipyfunctions are deprecated and cause warnings, and in future will cause errors.scipyis still used for interpolation and sparse matrices.cvlognet.py:l170glmnetPredict.py:l184I have also changed the
setup.pyso that the fortran extension is built automatically (which requiresgfortranto be installed). I am not sure whether you want this change, I guess updating the installation instructions here would be needed.There are a couple of changes to the author lines in
setup.pybrought in through merging you may want to revert too.Best wishes,
John Lees