[WIP] Inline identity function in TypeInfo[string]

[Copilot]

Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.

Original prompt

Inline the identity function at its only call site and remove the function definition from value/contained/types.go. Specifically:

• The identity function is currently defined as:

  func identity[T comparable](t T) (T, error) {
      return t, nil
  }

• It is only used as the FromString function in the TypeInfo[string] returned by the String() function in value/contained/types.go:

  func String() TypeInfo[string] {
      return TypeInfo[string]{
          Description: "string",
          Empty:       func() string { return "" },
          FromIFace: func(iFace interface{}) (string, error) {
              under, ok := iFace.(string)
              if !ok {
                  return "", ErrIncompatibleInterface
              }
              return under, nil
          },
          FromString: identity[string],
      }
  }

• Replace FromString: identity[string], with an inline closure: FromString: func(t string) (string, error) { return t, nil },
• Remove the identity function definition entirely.

This change is limited to value/contained/types.go.

This pull request was created as a result of the following prompt from Copilot chat.

Inline the identity function at its only call site and remove the function definition from value/contained/types.go. Specifically:

• The identity function is currently defined as:

  func identity[T comparable](t T) (T, error) {
      return t, nil
  }

• It is only used as the FromString function in the TypeInfo[string] returned by the String() function in value/contained/types.go:

  func String() TypeInfo[string] {
      return TypeInfo[string]{
          Description: "string",
          Empty:       func() string { return "" },
          FromIFace: func(iFace interface{}) (string, error) {
              under, ok := iFace.(string)
              if !ok {
                  return "", ErrIncompatibleInterface
              }
              return under, nil
          },
          FromString: identity[string],
      }
  }

• Replace FromString: identity[string], with an inline closure: FromString: func(t string) (string, error) { return t, nil },
• Remove the identity function definition entirely.

This change is limited to value/contained/types.go.

---

💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.