fix: strip Collapsed attribute from sanitized output#180
Closed
fix: strip Collapsed attribute from sanitized output#180
Conversation
petrowsky
force-pushed
the
fix/strip-collapsed-attribute
branch
3 times, most recently
from
38de6f9 to
32bcb7b
Compare
FileMaker's SaXML export now includes a Collapsed attribute on steps that reflects the UI collapse state of blocks in the Script Workspace. The exploder was surfacing this as literal text in sanitized output, producing noise like: If [ Collapsed: OFF ; $errorFind = 401 ] Else [ Collapsed: OFF ; Collapsed: OFF ] Add "Collapsed" to the de-noise filter in start_element_to_string so it is stripped in normal (lossy) mode. Lossless mode preserves it to maintain a faithful representation of the FM file state. Add unit tests confirming the attribute is stripped in lossy mode and preserved in lossless mode. Fixes bc-m#178
petrowsky
force-pushed
the
fix/strip-collapsed-attribute
branch
from
32bcb7b to
cd1cf66
Compare
Contributor
Author
|
Ignore this one. The fix was in the wrong place. Shouldn't be in xml_utils.rs, should be in boolean.rs. I'm updating it now. |
Owner
|
Okay! Please create a new PR then. :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
FileMaker's SaXML export now includes a
Collapsedattribute on steps that reflectswhether a block is visually collapsed in the Script Workspace. The exploder was passing
this through as a literal display value, producing noise like:
Fix
Add
"Collapsed"to the de-noise filter instart_element_to_string(
src/utils/xml_utils.rs), alongside the existingnextvalue,UUID, andindexexclusions. The attribute is stripped in normal (lossy) mode and preserved in lossless
mode to maintain a faithful representation of the FM file state.
Tests
Two new unit tests in
xml_utils.rs:test_collapsed_attribute_stripped_in_lossy_modetest_collapsed_attribute_preserved_in_lossless_modeFixes #178