build: pin the submodule to a commit that exists on the remote - #2001
Merged
johan-bell merged 1 commit intoSep 3, 2026
Merged
Conversation
CI could not clone the submodule:
fatal: remote error: upload-pack: not our ref fe8b0102…
Fetched in submodule path 'luminary-media-convert', but it did not
contain fe8b0102…
fe8b010 is a local commit in the nested checkout — it enables the
encoder's workflows by renaming .github.disabled to .github — and it was
never pushed, so nothing but that one working copy can resolve it. The
commit before it moved the pin back to ff0f6c9, which the #200 squash
orphaned when GitHub deleted the branch it was on.
Pinned to 6f4fcd9, the tip of the encoder's main, which reaches the same
end by a pushed route: #231 enables the test workflow there, and #230 is
in it too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the three red checks on #1910. They fail in the checkout step, after ~8 seconds:
What happened
Three commits moved the pin in a row:
ff98ab97(#2000)33e0ecfmain0257f734ff0f6c98f617ef8fe8b0102fe8b0102is a real commit, but only in the nested working copy atluminary/luminary-media-convert. It's titled "feat(workflows): add GitHub Actions for download metrics, FFmpeg build, pinned binaries health check, tests, and Windows installer" and it renames.github.disabled→.github. Nothing outside that one checkout can resolve it, so every runner fails to clone.The fix
Pinned to
6f4fcd9, the current tip of the encoder'smain— which reaches the same destination by a pushed route: #231 enables the test workflow there, and #230 (README corrections) is in it too.Note on the workflows
fe8b0102and #231 overlap. Encodermainnow carries both.github/workflows/tests.yml(from #231, updated for today's workspaces) and the original five in.github.disabled/, including a staletests.ymlthat still matrixes overhlsandsegment-editor— renamed and folded in by #187. Worth a tidy-up pass on the encoder side; it does not block this.