Skip to content

Bump the encoder submodule to current main - #2008

Open
johan-bell wants to merge 1 commit into
1878-api-cms-hls-media-data-modelfrom
1878-bump-encoder-pin
Open

Bump the encoder submodule to current main#2008
johan-bell wants to merge 1 commit into
1878-api-cms-hls-media-data-modelfrom
1878-bump-encoder-pin

Conversation

@johan-bell

Copy link
Copy Markdown
Collaborator

Moves the pin from 6f4fcd9 to 62522e5.

#236 the empty filter graph — every trimmed encode of 4+ re-encoded rungs failed on its second wave
#235 ship the web client once, not once per platform
#234 spawn npm through a shell on Windows
#233 collect-npm-licences could not run on Windows
#232 one workflows directory, and the four parked workflows made to run

Nothing in the range touches player-web-legacy, player-core or hls-core, so what this app builds from the submodule is byte-for-byte what it built before — the pin just stops trailing main.

Picks up the empty-filter-graph fix (#236), which is what made every
trimmed encode of more than three re-encoded rungs fail on its second
wave, along with the Windows build fixes and the workflow consolidation
(#232-#235).

Nothing in the range touches player-web-legacy, so what this app builds
is unchanged; the pin simply stops trailing main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant