Add support for Share permission in ACL and backfill for existing entries - #2011
Open
MrDirkelz wants to merge 12 commits into
Open
Add support for Share permission in ACL and backfill for existing entries#2011MrDirkelz wants to merge 12 commits into
MrDirkelz wants to merge 12 commits into
Conversation
- Add Telegram/WhatsApp share buttons on SingleContent, backed by new brand icon components and new locale strings - Rework the title/summary layout to overlay on the hero image when one is present, unifying the previous separate desktop/mobile blocks - Merge the metadata and bookmark rows into a single divided bar to make room for the new share actions
- Replace inline Telegram/WhatsApp share buttons with a unified ShareMenu component covering Telegram, WhatsApp, X, Reddit, and Instagram (clipboard-copy fallback), with new i18n strings for each platform. - Trim notification banner and hero header spacing on SingleContent/BasePage now that the share UI redesign changes the surrounding layout.
- Flatten the redundant wrapper div around IgnorePagePadding in the hero media section, fixing indentation without changing behavior - Adjust margin/gap spacing on the no-hero-image title block and notification banner for visual consistency
- Switch WhatsApp share to web.whatsapp.com since wa.me/api.whatsapp.com are OS-level Universal Links that hand off to the native app and drop the pre-filled share text - Widen ShareMenu panel and truncate long labels so translations don't overflow - Bump notification banner bottom margin for consistent spacing
Extract ShareMenu's Telegram/WhatsApp/X/Reddit URL builders and message formatting into a shared `useSocialShare` composable, then reuse it in LHighlightable so selecting article text surfaces the same share targets (plus a copy-to-clipboard fallback for Instagram) instead of only Highlight/Copy actions.
The selectionchange listener only registers after onMounted's async restoreHighlights() resolves, so tests dispatching selectionchange right after mount raced it. Also give the Instagram-share test suite an active testing Pinia, since shareHighlightToInstagram() reads the notification store.
Prefer the Web Share API on phones/tablets so the reader gets the apps actually installed on their device, keeping the curated share targets as the fallback for desktop and for browsers without Web Share. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.