Environment Canada New Form Fields#703
Open
ionwyn wants to merge 16 commits into
Open
Conversation
This reverts commit 675e11f. Signed-off-by: Ionwyn Sean <ionwynsean@gmail.com>
ionwyn
changed the title
Signed-off-by: Ionwyn Sean <ionwynsean@gmail.com>
Signed-off-by: Ionwyn Sean <ionwynsean@gmail.com>
ionwyn
commented
May 29, 2026
| public sealed class SaltReportMap : ClassMap<HmrSaltReport> | ||
| { | ||
| public SaltReportMap() | ||
| { |
Collaborator
Author
There was a problem hiding this comment.
WARNING! This change looks huge because previously the logic was:
- INCLUDE everything but ignore what I explicitly write.
Now:
- Explicitly INCLUDE only what we want (which is still a lot, but cut included size and CSV build time by ~2.3s)
ionwyn
commented
May 29, 2026
Collaborator
Author
There was a problem hiding this comment.
WARNING! The changes here look huge because previous logic was
- Literally write CSV here
But I got really confused, so I asked AI to replace it a map.
ionwyn
commented
May 29, 2026
Collaborator
Author
There was a problem hiding this comment.
Added new validations for new data and Optimized ValidationSchema via DRY principle
ionwyn
commented
May 29, 2026
Collaborator
Author
There was a problem hiding this comment.
WARNING!
This file looks HUGE. We had to backfill previous data including history table for the new columns as those columns accept NULL but not EMPY by design.
rogene-bcgov
approved these changes
May 29, 2026
Signed-off-by: Ionwyn Sean <ionwynsean@gmail.com>
This reverts commit 1875f7b.
Signed-off-by: Ionwyn Sean <ionwynsean@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The purpose of this pull request is to satisfy Environment Canada requirements of having the 2025/2026 season annual salt reporting.
Environment Canada requires additions of new form fields and descriptions.
The migration adds 19 new columns, has been approved and executed in DEV, TEST, and UAT by Doug Bilinski at ticket HMCR-1135