Skip to content

NOBUG: Fix migrations broken by recent schema updates #1853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
molund merged 2 commits into from
Jun 5, 2026
Merged

NOBUG: Fix migrations broken by recent schema updates #1853

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dbf7ad7
NOBUG: Fix migrations broken by recent schema updates
molund Jun 5, 2026
0a0a9c8
Use a different way to check
molund Jun 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
27 changes: 21 additions & 6 deletions src/cms/database/migrations/2026.03.21T00.00.004a-populate-closed-rst-resources.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,12 +229,27 @@ function titleCase(str) {
module.exports = {
async up(knex) {
if (await knex.schema.hasTable("recreation_resources")) {
await knex.raw(
"DELETE FROM public_advisory_audits WHERE submitted_by = 'Imported'",
);
await knex.raw(
"DELETE FROM public_advisories WHERE submitted_by = 'Imported'",
);
if (
await knex.schema.hasColumn(
"public_advisory_audits",
"submitted_by_name",
)
) {
await knex.raw(
"DELETE FROM public_advisory_audits WHERE submitted_by_name = 'Imported'",
);

await loadData();
}

if (
await knex.schema.hasColumn("public_advisories", "submitted_by_name")
) {
await knex.raw(
"DELETE FROM public_advisories WHERE submitted_by_name = 'Imported'",
);
}

await loadData();
}
},
Expand Down
12 changes: 12 additions & 0 deletions src/cms/database/migrations/2026.05.20T00.00.012-import-standard-messages.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,6 +110,17 @@ const messages = [
module.exports = {
async up(knex) {
if (await knex.schema.hasTable("standard_messages")) {
// If precedence 30 already exists, this migration has already imported all rows.
const precedence30Exists = await knex("standard_messages")
.where({ precedence: 30 })
.first();
if (precedence30Exists) {
strapi.log.info(
"Standard messages already imported (precedence 30 exists). Skipping migration.",
);
return;
}

// create a map of event type names (eventType field) to documentIds
const eventTypes = await knex("event_types").select(
"document_id",
Expand Down Expand Up @@ -140,6 +151,7 @@ module.exports = {
precedence,
description,
eventType: eventTypeDocId,
isActive: true,
},
});
}
Expand Down