Skip to content

32006 Generate a new UUID for any share class with a null id as part of the draft filings formatter#506

Merged
vysakh-menon-aot merged 3 commits into
bcgov:mainfrom
vysakh-menon-aot:feature/32006
Jun 29, 2026
Merged

32006 Generate a new UUID for any share class with a null id as part of the draft filings formatter#506
vysakh-menon-aot merged 3 commits into
bcgov:mainfrom
vysakh-menon-aot:feature/32006

Conversation

@vysakh-menon-aot

Copy link
Copy Markdown
Collaborator

Issue #: /bcgov/entity#32006

Description of changes:

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of the business-ui license (BSD 3-Clause).

@vysakh-menon-aot

Copy link
Copy Markdown
Collaborator Author

/gcbrun

@deetz99

deetz99 commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

We rely on the ID in the composable, does the edit/change priority functionality still work when the ID is null?

@vysakh-menon-aot

Copy link
Copy Markdown
Collaborator Author

We rely on the ID in the composable, does the edit/change priority functionality still work when the ID is null?

Good catch!

@vysakh-menon-aot

Copy link
Copy Markdown
Collaborator Author

/gcbrun

@deetz99 deetz99 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Can you please update the changeset though?

I think we can ignore the CI build for now, SRE is upgrading to pnpm 11 and there's some workspace/config changes needed which is why the build is failing currently.

@vysakh-menon-aot vysakh-menon-aot changed the title 32006 allow null id in share chass formatter to support draft filings 32006 Generate a new UUID for any share class with a null id as part of the draft filings formatter Jun 29, 2026
@vysakh-menon-aot vysakh-menon-aot merged commit 820e46e into bcgov:main Jun 29, 2026
30 of 36 checks passed
@vysakh-menon-aot vysakh-menon-aot deleted the feature/32006 branch June 29, 2026 20:14
@github-actions github-actions Bot mentioned this pull request Jun 29, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants