Skip to content

[SMT-66] [SMT-67] [SMT-68] Change header colours #2245

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ionwyn merged 1 commit into from
Apr 30, 2026
Merged

[SMT-66] [SMT-67] [SMT-68] Change header colours #2245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion client/src/js/views/TopNav.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import PropTypes from 'prop-types';
import React from 'react';
import { connect } from 'react-redux';
import { withRouter, NavLink } from 'react-router-dom';
import classNames from 'classnames';
import _ from 'lodash';
import {
Navbar,
Expand Down Expand Up @@ -79,7 +80,7 @@ class TopNav extends React.Component {
}

return (
<div id="header" className="sticky-top">
<div id="header" className={classNames('sticky-top', environmentClass)}>
<Navbar id="header-main">
<Container className={'justify-content-start'}>
<Navbar.Brand href="http://www2.gov.bc.ca/gov/content/home">
Expand Down
15 changes: 15 additions & 0 deletions client/src/sass/header.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,21 @@ $nav-active-background-color-uat: lighten($nav-background-color-uat, 10%);
}
}

#header {
Comment on lines 39 to +41
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are now two separate #header { ... } blocks in this file (one for banner/working-indicator and one for env-specific #header-main background). Consider merging them into a single #header block to keep related header styling together and reduce the chance of future conflicting edits.

Suggested change
}
#header {

Copilot uses AI. Check for mistakes.
&.env-dev #header-main {
background-color: $nav-background-color-dev;
}

&.env-test #header-main {
background-color: $nav-background-color-test;
}

&.env-trn #header-main,
&.env-uat #header-main {
background-color: $nav-background-color-uat;
}
Comment on lines +48 to +53
Copy link

Copilot AI Apr 8, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

env-trn is grouped with env-uat for #header-main, but there are no corresponding #top-nav.env-trn styles (only env-test/dev/uat). As a result, Training will get UAT colouring for #header-main while #top-nav stays at the default colour. Either add &.env-trn rules under #top-nav (likely matching UAT), or remove env-trn from here and map Training to an existing environment class.

Copilot uses AI. Check for mistakes.
}

#top-nav {
margin-bottom: 0;
background-color: $nav-background-color;
Expand Down
Loading