Fix mdist() to look up maps in the ssdtools namespace only - #481
Merged
Conversation
Attached packages exporting m* helpers (notably actuar) no longer break ssd_fit_dists(); add regression tests including actuar attached and search-path clashes. Co-authored-by: Cursor <cursoragent@cursor.com>
joethorley
approved these changes
Aug 4, 2026
joethorley
added a commit
to poissonconsulting/ssdtools
that referenced
this pull request
Aug 6, 2026
fledge derived the entry from merge-commit subjects because the PR lookups 404'd: this repo is a fork of bcgov/ssdtools and the merge commits reference upstream PR numbers (bcgov#472, bcgov#478, bcgov#480, bcgov#481) that do not exist in poissonconsulting/ssdtools. That left four raw 'Merge pull request' bullets plus a duplicate of the 2.6.0.9002 entry. Replaced with the user-facing changes since v2.6.0.9002.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mdist()toasNamespace(ssdtools)so attached packages that exportm*helpers (notably actuar) no longer breakssd_fit_dists()(ssd_fit_dists() fails for all distributions when actuar is attached (mdist() calls m<dist>() with no arguments) #479).minvpareto()for the invpareto TMB map).mlnormclash, and fitting withactuarattached (including censored data).Test plan
tests/testthat/test-mdist.R(9 expectations) against a local install of this branchtest-invpareto.Randtest-fit-dists.Rstill passCloses #479