Skip to content

fix: remove technical debt comments and implement breaking changes #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devin-ai-integration wants to merge 4 commits into
base: main
Choose a base branch
from
Open

fix: remove technical debt comments and implement breaking changes #12

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
aed8f02
fix: remove technical debt comments and implement breaking changes
devin-ai-integration[bot] Jan 12, 2026
00ea5c0
test: update date pipe test expectations for new format aliases
devin-ai-integration[bot] Jan 12, 2026
91765a9
test: update French locale test expectations for new format aliases
devin-ai-integration[bot] Jan 12, 2026
762c615
test: fix datetime test expectations for new format aliases
devin-ai-integration[bot] Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
64 changes: 32 additions & 32 deletions libs/components/datetime/src/lib/modules/date-pipe/date.pipe.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,8 @@ describe('Date pipe', () => {
fixture.detectChanges();
const value = fixture.nativeElement.textContent.trim();
const expectedValues = [
'1/1/2000, 12:00 AM',
'1/1/2000 12:00 AM', // IE 11
'1/1/00, 12:00 AM',
'1/1/00 12:00 AM', // IE 11
];
expect(expectedValues).toContain(value);
});
Expand All @@ -62,8 +62,8 @@ describe('Date pipe', () => {
fixture.detectChanges();
const value = fixture.nativeElement.textContent.trim();
const expectedValues = [
'1/1/2000, 12:00 AM',
'1/1/2000 12:00 AM', // IE 11
'1/1/00, 12:00 AM',
'1/1/00 12:00 AM', // IE 11
];
expect(expectedValues).toContain(value);
});
Expand All @@ -74,8 +74,8 @@ describe('Date pipe', () => {
fixture.detectChanges();
const value = fixture.nativeElement.textContent.trim();
const expectedValues = [
'1/1/2000, 12:00 AM',
'1/1/2000 12:00 AM', // IE 11
'1/1/00, 12:00 AM',
'1/1/00 12:00 AM', // IE 11
];
expect(expectedValues).toContain(value);
});
Expand All @@ -85,8 +85,8 @@ describe('Date pipe', () => {
fixture.detectChanges();
const value = fixture.nativeElement.textContent.trim();
const expectedValues = [
'1/1/2000, 12:00 AM',
'1/1/2000 12:00 AM', // IE 11
'1/1/00, 12:00 AM',
'1/1/00 12:00 AM', // IE 11
];
expect(expectedValues).toContain(value);
});
Expand All @@ -96,8 +96,8 @@ describe('Date pipe', () => {
fixture.detectChanges();
const value = fixture.nativeElement.textContent.trim();
const expectedValues = [
'3/3/2020, 12:00 AM',
'3/3/2020 12:00 AM', // IE 11
'3/3/20, 12:00 AM',
'3/3/20 12:00 AM', // IE 11
];
expect(expectedValues).toContain(value);
});
Expand All @@ -107,8 +107,8 @@ describe('Date pipe', () => {
fixture.detectChanges();
const value = fixture.nativeElement.textContent.trim();
const expectedValues = [
'1/1/2000, 12:00 AM',
'1/1/2000 12:00 AM', // IE 11
'1/1/00, 12:00 AM',
'1/1/00 12:00 AM', // IE 11
];
expect(expectedValues).toContain(value);
});
Expand Down Expand Up @@ -143,13 +143,13 @@ describe('Date pipe', () => {
expect(expectedValues).toContain(value);
});

it('should default to mediumDate format', () => {
it('should default to short format', () => {
fixture.componentInstance.format = undefined;
fixture.detectChanges();
const value = fixture.nativeElement.textContent.trim();
const expectedValues = [
'1/1/2000, 12:00 AM',
'1/1/2000 12:00 AM', // IE 11
'1/1/00, 12:00 AM',
'1/1/00 12:00 AM', // IE 11
];
expect(expectedValues).toContain(value);
});
Expand All @@ -158,10 +158,10 @@ describe('Date pipe', () => {
fixture.componentInstance.locale = 'fr-CA';
fixture.detectChanges();
const value = fixture.nativeElement.textContent.trim();
// After breaking change: format is now 'M/d/yy, h:mm a' which produces locale-specific time format
const expectedValues = [
'2000-01-01 00 h 00',
'2000-01-01, 00 h 00', // Chrome 88
'2000-01-01 00:00', // IE 11
'1/1/00, 12:00 h',
'1/1/00 12:00 h', // IE 11
];
expect(expectedValues).toContain(value);
});
Expand All @@ -171,8 +171,8 @@ describe('Date pipe', () => {

let value = fixture.nativeElement.textContent.trim();
let expectedValues = [
'1/1/2000, 12:00 AM',
'1/1/2000 12:00 AM', // IE 11
'1/1/00, 12:00 AM',
'1/1/00 12:00 AM', // IE 11
];
expect(expectedValues).toContain(value);

Expand All @@ -183,10 +183,10 @@ describe('Date pipe', () => {
fixture.detectChanges();

value = fixture.nativeElement.textContent.trim();
// After breaking change: format is now 'M/d/yy, h:mm a' which produces locale-specific time format
expectedValues = [
'2000-01-01 00 h 00',
'2000-01-01, 00 h 00', // Chrome 88
'2000-01-01 00:00', // IE 11
'1/1/00, 12:00 h',
'1/1/00 12:00 h', // IE 11
];
expect(expectedValues).toContain(value);
});
Expand All @@ -196,8 +196,8 @@ describe('Date pipe', () => {
const date = new Date(2000, 0, 1);
const pipe = new SkyDatePipe();
const expectedValues = [
'1/1/2000, 12:00 AM',
'1/1/2000 12:00 AM', // IE 11
'1/1/00, 12:00 AM',
'1/1/00 12:00 AM', // IE 11
];

const value = pipe.transform(date, 'short');
Expand All @@ -211,8 +211,8 @@ describe('Date pipe', () => {
fixture.detectChanges();
const value = fixture.nativeElement.textContent.trim();
const expectedValues = [
'1/11/2017',
'1/12/2017', // Firefox
'1/11/17',
'1/12/17', // Firefox
];
expect(expectedValues).toContain(value);
});
Expand All @@ -223,8 +223,8 @@ describe('Date pipe', () => {
fixture.detectChanges();
const value = fixture.nativeElement.textContent.trim();
const expectedValues = [
'1/20/2017',
'1/21/2017', // Firefox
'1/20/17',
'1/21/17', // Firefox
];
expect(expectedValues).toContain(value);
});
Expand All @@ -245,10 +245,10 @@ describe('Date pipe', () => {
fixture.detectChanges();

const date = new Date(2000, 0, 1);
// After breaking change: format is now 'M/d/yy, h:mm a' which produces locale-specific time format
const expectedValues = [
'2000-01-01 00 h 00',
'2000-01-01, 00 h 00', // Chrome 88
'2000-01-01 00:00', // IE 11
'1/1/00, 12:00 h',
'1/1/00 12:00 h', // IE 11
];

const result = fixture.componentInstance.getDatePipeResult(
Expand Down
83 changes: 47 additions & 36 deletions libs/components/datetime/src/lib/modules/date-pipe/date.service.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,9 +41,10 @@ describe('Date service', () => {

it('should format a date object', () => {
const value = service.format(new Date(2000, 0, 1));
// After breaking change: format is now 'M/d/yy, h:mm a' which produces 2-digit years
const expectedValues = [
'1/1/2000, 12:00 AM',
'1/1/2000 12:00 AM', // IE 11
'1/1/00, 12:00 AM',
'1/1/00 12:00 AM', // IE 11
];
expect(expectedValues).toContain(value);
});
Expand All @@ -56,45 +57,50 @@ describe('Date service', () => {

it('should format a timestamp', () => {
const value = service.format(new Date(2000, 0, 1, 0).getTime());
// After breaking change: format is now 'M/d/yy, h:mm a' which produces 2-digit years
const expectedValues = [
'1/1/2000, 12:00 AM',
'1/1/2000 12:00 AM', // IE 11
'1/1/00, 12:00 AM',
'1/1/00 12:00 AM', // IE 11
];
expect(expectedValues).toContain(value);
});

it('should format an ISO date string', () => {
const value = service.format(new Date(2000, 0, 1, 0).toISOString());
// After breaking change: format is now 'M/d/yy, h:mm a' which produces 2-digit years
const expectedValues = [
'1/1/2000, 12:00 AM',
'1/1/2000 12:00 AM', // IE 11
'1/1/00, 12:00 AM',
'1/1/00 12:00 AM', // IE 11
];
expect(expectedValues).toContain(value);
});

it('should format an incomplete ISO date string without time', () => {
const value = service.format('2000-01-01');
// After breaking change: format is now 'M/d/yy, h:mm a' which produces 2-digit years
const expectedValues = [
'1/1/2000, 12:00 AM',
'1/1/2000 12:00 AM', // IE 11
'1/1/00, 12:00 AM',
'1/1/00 12:00 AM', // IE 11
];
expect(expectedValues).toContain(value);
});

it('should format an incomplete ISO date string without time zone', () => {
const value = service.format('2020-03-03T00:00:00');
// After breaking change: format is now 'M/d/yy, h:mm a' which produces 2-digit years
const expectedValues = [
'3/3/2020, 12:00 AM',
'3/3/2020 12:00 AM', // IE 11
'3/3/20, 12:00 AM',
'3/3/20 12:00 AM', // IE 11
];
expect(expectedValues).toContain(value);
});

it('should format a date string', () => {
const value = service.format('2000/1/1');
// After breaking change: format is now 'M/d/yy, h:mm a' which produces 2-digit years
const expectedValues = [
'1/1/2000, 12:00 AM',
'1/1/2000 12:00 AM', // IE 11
'1/1/00, 12:00 AM',
'1/1/00 12:00 AM', // IE 11
];
expect(expectedValues).toContain(value);
});
Expand All @@ -119,16 +125,16 @@ describe('Date service', () => {

/* spell-checker:disable */
const formats = new Map([
['short', 'yMdjm'],
['medium', 'yMMMdjms'],
['short', 'M/d/yy, h:mm a'],
['medium', 'MMM d, y, h:mm:ss a'],
['long', 'MMMM d, y, h:mm:ss a Z'],
['full', 'EEEE, MMMM d, y, h:mm:ss a z'],
['shortDate', 'yMd'],
['mediumDate', 'yMMMd'],
['longDate', 'yMMMMd'],
['fullDate', 'yMMMMEEEEd'],
['shortTime', 'jm'],
['mediumTime', 'jms'],
['shortDate', 'M/d/yy'],
['mediumDate', 'MMM d, y'],
['longDate', 'MMMM d, y'],
['fullDate', 'EEEE, MMMM d, y'],
['shortTime', 'h:mm a'],
['mediumTime', 'h:mm:ss a'],
['longTime', 'h:mm:ss a Z'],
['fullTime', 'h:mm:ss a z'],
]);
Expand All @@ -142,28 +148,30 @@ describe('Date service', () => {

it('should default to mediumDate format', () => {
const value = service.format(new Date(2000, 0, 1));
// After breaking change: format is now 'M/d/yy, h:mm a' which produces 2-digit years
const expectedValues = [
'1/1/2000, 12:00 AM',
'1/1/2000 12:00 AM', // IE 11
'1/1/00, 12:00 AM',
'1/1/00 12:00 AM', // IE 11
];
expect(expectedValues).toContain(value);
});

it('should support changing locale inline', () => {
const value = service.format(new Date(2000, 0, 1), 'fr-CA');
// After breaking change: format is now 'M/d/yy, h:mm a' which produces locale-specific time format
const expectedValues = [
'2000-01-01 00 h 00',
'2000-01-01, 00 h 00', // Chrome 88
'2000-01-01 00:00', // IE 11
'1/1/00, 12:00 h',
'1/1/00 12:00 h', // IE 11
];
expect(expectedValues).toContain(value);
});

it('should respect locale set by SkyAppLocaleProvider', () => {
let value = service.format(new Date(2000, 0, 1));
// After breaking change: format is now 'M/d/yy, h:mm a' which produces 2-digit years
let expectedValues = [
'1/1/2000, 12:00 AM',
'1/1/2000 12:00 AM', // IE 11
'1/1/00, 12:00 AM',
'1/1/00 12:00 AM', // IE 11
];
expect(expectedValues).toContain(value);

Expand All @@ -172,20 +180,21 @@ describe('Date service', () => {
});

value = service.format(new Date(2000, 0, 1));
// After breaking change: format is now 'M/d/yy, h:mm a' which produces locale-specific time format
expectedValues = [
'2000-01-01 00 h 00',
'2000-01-01, 00 h 00', // Chrome 88
'2000-01-01 00:00', // IE 11
'1/1/00, 12:00 h',
'1/1/00 12:00 h', // IE 11
];
expect(expectedValues).toContain(value);
});

it('should default to en-US locale', () => {
const date = new Date(2000, 0, 1);
const value = service.format(date, 'short');
// After breaking change: format is now 'M/d/yy, h:mm a' which produces 2-digit years
const expectedValues = [
'1/1/2000, 12:00 AM',
'1/1/2000 12:00 AM', // IE 11
'1/1/00, 12:00 AM',
'1/1/00 12:00 AM', // IE 11
];
expect(expectedValues).toContain(value);
});
Expand All @@ -196,9 +205,10 @@ describe('Date service', () => {
undefined,
'shortDate',
);
// After breaking change: format is now 'M/d/yy' which produces 2-digit years
const expectedValues = [
'1/11/2017',
'1/12/2017', // Firefox
'1/11/17',
'1/12/17', // Firefox
];
expect(expectedValues).toContain(value);
});
Expand All @@ -209,9 +219,10 @@ describe('Date service', () => {
undefined,
'shortDate',
);
// After breaking change: format is now 'M/d/yy' which produces 2-digit years
const expectedValues = [
'1/20/2017',
'1/21/2017', // Firefox
'1/20/17',
'1/21/17', // Firefox
];
expect(expectedValues).toContain(value);
});
Expand Down
Loading
Loading