Skip to content

chore: fix for stx validator #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vr16x merged 2 commits into from
Feb 12, 2026
Merged

chore: fix for stx validator #177

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d5af7e9
chore: fix for stx validator
Feb 12, 2026
8f89008
chore: format
Feb 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/modules/quotes/quotes.service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1263,8 +1263,15 @@ export class QuotesService {
} as const;

// Decode SafeTxnData from signatureData
const [safeTxnData] = decodeAbiParameters(
[safeTxnDataAbi],
const [safeAccount, safeTxnData] = decodeAbiParameters(
[
{ name: "safeAccount", type: "address" },
{
name: "safeTxnData",
type: "tuple",
components: safeTxnDataAbi.components,
},
],
Comment on lines +1266 to +1274
Copy link
Copy Markdown
Collaborator

@vr16x vr16x Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This doesn't affect backwards compatibility ? Extra params and order is changed here while decoding

Copy link
Copy Markdown
Author

@filmakarov filmakarov Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there's no backwards compatibility

no one uses previous version (2.3.0) since it was experimental and unaudited

Copy link
Copy Markdown
Collaborator

@vr16x vr16x Feb 12, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good then

signatureData,
);

Expand All @@ -1276,6 +1283,7 @@ export class QuotesService {
{
type: "tuple",
components: [
{ name: "safeAccount", type: "address" },
safeTxnDataAbi,
{ name: "proof", type: "bytes32[]" },
{ name: "executeTrigger", type: "bool" },
Expand All @@ -1286,6 +1294,7 @@ export class QuotesService {
],
[
{
safeAccount,
safeTxnData,
proof,
// For sponsored supertransactions, the Safe tx execution will happen in first user defined userOp
Expand Down