feat: p256 validator modes support

[filmakarov]

• add p256 simple mode
• make execQuote support it
• unify swicth/cases to use quote type, not a sig type

[fichiokaku]

lg2m!

[vr16x]

Quote type is not provided by all the SDKs. Some old SDKs still don't send this and it might be a breaking change.

Let's revert back to the same approach

[filmakarov]

There's this code block

[filmakarov]

It makes sure quote type is always defined.

[vr16x]

I can't see the screenshot

[filmakarov]

So there's no need to revert to the same approach
This code is much cleaner. Previous approach was confusing => quote type and sig type were mixed together , while they mean pretty miuch same

[vr16x]

Can you reshare the pic, I see quoteType is optional in schema definition.

Sig type is good for backwards compatibility.

[vr16x]

Got it, all good. Yup I added this code block earlier for backwards compatibility.

I will merge this

[filmakarov]

quoteType is optional in schema definition.

it is optional. but in the code it is always defined!

if (!options.quoteType) {
      if (signatureType === MeeSignatureType.OFF_CHAIN) {
      if (
        signatureType === MeeSignatureType.OFF_CHAIN ||
        signatureType === MeeSignatureType.OFF_CHAIN_P256
      ) {
        quoteType = "simple";
      } else if (signatureType === MeeSignatureType.ON_CHAIN) {
        quoteType = "onchain";
      } else if (signatureType === MeeSignatureType.ERC20_PERMIT) {
        quoteType = "permit";
      } else if (signatureType === MeeSignatureType.MM_DTK) {
        quoteType = "mm-dtk";
      } else if (signatureType === MeeSignatureType.SAFE_SA) {
        quoteType = "safe-sa";
      } else {
        throw new BadRequestException(
          `Unsupported signature type for quote type detection ${signatureType}`,
        );
      }
    } else {
      quoteType = options.quoteType;
    }

[vr16x]

However, initially its optional and its optional in quote phase.

[filmakarov]

quote type is also better because two sig types (and more in future) can be still same quote type

[vr16x]

Please don't use quoteType. Its not a mandatory field because old versions of SDK don't send them

[vr16x]

LG2M