Skip to content

feat: added a 15 days storage expiration for stx info#200

Merged
vr16x merged 4 commits intodevelopfrom
feat/cache-expirations
Mar 23, 2026
Merged

feat: added a 15 days storage expiration for stx info#200
vr16x merged 4 commits intodevelopfrom
feat/cache-expirations

Conversation

@vr16x
Copy link
Copy Markdown
Collaborator

@vr16x vr16x commented Mar 17, 2026

No description provided.

@vr16x vr16x requested a review from fichiokaku March 19, 2026 16:07
Copy link
Copy Markdown
Collaborator

@fichiokaku fichiokaku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

createQuote sets ttl on quote:* and user-op:*:data, but follow-up updates mostly call updateUserOpCustomFields, which only EXPIREs user-op:*:custom-fields.

so the :data (and quote) keys keep the original countdown from quote creation, while custom-fields can be extended on every update — possible mismatch or short-lived data with longer-lived custom-fields, depending on traffic.

worth deciding explicitly is that ok? or should we refresh ttl on the related keys in the same code paths (if we have the keys in context)?

@vr16x
Copy link
Copy Markdown
Collaborator Author

vr16x commented Mar 20, 2026

createQuote sets ttl on quote:* and user-op:*:data, but follow-up updates mostly call updateUserOpCustomFields, which only EXPIREs user-op:*:custom-fields.

so the :data (and quote) keys keep the original countdown from quote creation, while custom-fields can be extended on every update — possible mismatch or short-lived data with longer-lived custom-fields, depending on traffic.

worth deciding explicitly is that ok? or should we refresh ttl on the related keys in the same code paths (if we have the keys in context)?

Really a good question. This is not a problem for us until the initial 15 days and we assume the data pipelines will complete the job within this duration.

Once after this, the only place where those keys are used is from the explorer endpoint which initially checks if quote is there or not. 100% of the time, if the quote is expired, the API will throw an error and never attempts to consume those custom fields even if they have extended expiration time

@vr16x vr16x requested a review from fichiokaku March 23, 2026 05:42
@vr16x vr16x merged commit 1342aea into develop Mar 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants