Skip to content

Ogimet improvements and SYNOP parser - #116

Merged
bczernecki merged 38 commits into
masterfrom
115-synop_parser-and-ogimet-improvements
Jul 10, 2026
Merged

Ogimet improvements and SYNOP parser#116
bczernecki merged 38 commits into
masterfrom
115-synop_parser-and-ogimet-improvements

Conversation

@bczernecki

@bczernecki bczernecki commented Nov 7, 2025

Copy link
Copy Markdown
Owner

This PR addresses quite numerous changes that were hanging for some time:

  • Including SYNOP parser/decoder for meteorological data - mostly based on Ogimet service
  • refactor of meteo_ogimet()
  • adding telemetrical/datastore resources for meteo_imgw() wrapper
  • minor fixes in hydro_imgw
  • computing relative humidity based on air temperature and dew_point temperature to adjust output to rendered in the ogimet's tables
  • updates in documentation

@bczernecki bczernecki linked an issue Nov 7, 2025 that may be closed by this pull request
3 tasks
@codecov

codecov Bot commented Nov 7, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 91.38943% with 132 lines in your changes missing coverage. Please review.
✅ Project coverage is 90.57%. Comparing base (a9deb55) to head (6396adb).

Files with missing lines Patch % Lines
R/parser.R 92.69% 88 Missing ⚠️
R/meteo_ogimet_synop.R 88.65% 22 Missing ⚠️
R/meteo_ogimet.R 76.81% 16 Missing ⚠️
R/meteo_imgw.R 73.91% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #116      +/-   ##
==========================================
+ Coverage   87.81%   90.57%   +2.75%     
==========================================
  Files          33       36       +3     
  Lines        1839     3331    +1492     
==========================================
+ Hits         1615     3017    +1402     
- Misses        224      314      +90     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bczernecki bczernecki self-assigned this May 10, 2026
@bczernecki bczernecki added documentation Improvements or additions to documentation enhancement New feature or request labels May 12, 2026
@bczernecki
bczernecki marked this pull request as draft May 12, 2026 12:47
@bczernecki
bczernecki requested review from Nowosad and aglogowski May 13, 2026 22:10
@bczernecki
bczernecki marked this pull request as ready for review May 13, 2026 22:14
Comment thread R/hydro_imgw_daily.R Outdated
Comment thread R/compute_relative_humidity.R
Comment thread vignettes/articles/synop_parser.Rmd Outdated
Comment thread tests/testthat/test-synop_parser.R
@Nowosad

Nowosad commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

@bczernecki -- also check if the https://bczernecki.github.io/climate/articles/synop_parser.html website is working (you link to it in a few places), before submitting the package to CRAN.

@Nowosad

Nowosad commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

@bczernecki Just to let you know -- I also did not fully checked the new parser function (nor its unit tests). It is a bit outside of my understanding. The rest looks fine (see my comments above).

@bczernecki
bczernecki merged commit 2bd1b02 into master Jul 10, 2026
8 of 9 checks passed
@Nowosad
Nowosad deleted the 115-synop_parser-and-ogimet-improvements branch July 10, 2026 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SYNOP_parser and ogimet improvements

2 participants