Ogimet improvements and SYNOP parser - #116
Merged
Merged
Conversation
3 tasks
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #116 +/- ##
==========================================
+ Coverage 87.81% 90.57% +2.75%
==========================================
Files 33 36 +3
Lines 1839 3331 +1492
==========================================
+ Hits 1615 3017 +1402
- Misses 224 314 +90 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Merge remote-tracking branch 'origin/master' into 115-synop_parser-and-ogimet-improvements # Conflicts: # R/hydro_imgw_daily.R # R/meteo_imgw_daily.R
bczernecki
marked this pull request as draft
May 12, 2026 12:47
bczernecki
marked this pull request as ready for review
May 13, 2026 22:14
Nowosad
reviewed
Jul 3, 2026
Collaborator
|
@bczernecki -- also check if the https://bczernecki.github.io/climate/articles/synop_parser.html website is working (you link to it in a few places), before submitting the package to CRAN. |
Collaborator
|
@bczernecki Just to let you know -- I also did not fully checked the new parser function (nor its unit tests). It is a bit outside of my understanding. The rest looks fine (see my comments above). |
…:bczernecki/climate into 115-synop_parser-and-ogimet-improvements
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses quite numerous changes that were hanging for some time:
meteo_ogimet()meteo_imgw()wrapperhydro_imgw