fix: improve Slack unavailable messaging for end users

[bd73-com]

Summary

PR #91 made the Slack notification card always visible, but when the server reports available: false, end users now see "Contact your administrator to set up the Slack app" — a confusing admin-targeted message they cannot act on. This PR replaces that generic message with specific, user-friendly text by splitting the server's single unavailableReason into two distinct reasons.

Changes

API contract (shared/routes.ts)

• Replace unavailableReason: "unavailable" enum with "tables-not-ready" | "oauth-not-configured"

Server (server/routes.ts)

• Split the combined !tablesReady || !oauthReady check into two sequential early returns, each with its own reason
• Tables checked first (transient/recoverable), OAuth second (needs admin)

Client display logic (slack-display-state.ts, use-slack.ts)

• Add "not-ready" display state for transient table failures
• Derive SlackStatus type from Zod schema via z.infer<...> (single source of truth)
• Deduplicate SlackStatus interface (was defined in two files)

UI (NotificationChannelsPanel.tsx)

• tables-not-ready → "Slack notifications are temporarily unavailable. Please try again in a moment."
• oauth-not-configured → "Slack notifications are not available for this service."
• Replace 5-deep ternary chain with IIFE + early returns (calls getSlackDisplayState once instead of 4×)

Tests (slack-display-state.test.ts, routes.notificationChannels.test.ts, routes.test.ts)

• 9 new tests: Zod schema validation (accepts/rejects reason values), isolated table-failure scenario, precedence of available: false over connected: true
• Updated 6 existing tests for new reason values

How to test

• Start the app without SLACK_CLIENT_ID/SLACK_CLIENT_SECRET env vars set
• Navigate to a monitor's notification channels panel
• Verify the Slack section shows "Slack notifications are not available for this service." (not "Contact your administrator")
• Set SLACK_CLIENT_ID and SLACK_CLIENT_SECRET to valid values, restart
• Verify the Slack section shows "Connect to Slack" button
• Run npm run test — all 1161 tests pass
• Run npm run build — production build succeeds

https://claude.ai/code/session_01RSvtzrtyhYtfcAb9Mm4BR4

Summary by CodeRabbit

• New Features

  • Added "not-ready" Slack state to clarify when tables aren't initialized.
  • Enhanced Slack setup with distinct messages for configuration and readiness issues.

• UI Improvements

  • Redesigned Slack connection panel with separate Disconnect button and channel selection controls.
  • Improved button styling and messaging throughout Slack setup flow.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 566edb17-a323-4445-9433-62776ff99109

📥 Commits

Reviewing files that changed from the base of the PR and between 8ea2155 and c91a28c.

📒 Files selected for processing (8)

• client/src/components/NotificationChannelsPanel.tsx
• client/src/components/slack-display-state.test.ts
• client/src/components/slack-display-state.ts
• client/src/hooks/use-slack.ts
• server/routes.notificationChannels.test.ts
• server/routes.ts
• shared/routes.test.ts
• shared/routes.ts

---

📝 Walkthrough

Walkthrough

The PR refactors Slack integration handling to distinguish between missing database tables (tables-not-ready) and missing OAuth configuration (oauth-not-configured). Changes span client UI rendering, server status endpoint logic, and shared API schema to support this new state distinction with enhanced test coverage.

Changes

Cohort / File(s)	Summary
Slack Display State Logic client/src/components/slack-display-state.ts, client/src/components/slack-display-state.test.ts	Adds "not-ready" to SlackDisplayState type; imports SlackStatus from hooks instead of defining locally. Updates getSlackDisplayState to branch on unavailableReason ("tables-not-ready" vs. "oauth-not-configured"). Expands tests to cover new states and validate precedence rules.
Client UI Components client/src/components/NotificationChannelsPanel.tsx	Refactors nested ternary chains into explicit IIFE for Slack state rendering. Introduces "loading" state for non-free tier status fetches, "not-ready" state with new messaging, and splits connected UI into dedicated block with Disconnect and channel selection controls.
Client Hooks & Types client/src/hooks/use-slack.ts	Replaces SlackStatus interface with zod-inferred type derived from API schema, importing z from zod for type inference.
Server Route Handlers server/routes.ts, server/routes.notificationChannels.test.ts	Separates unavailability logic: returns "tables-not-ready" when channel tables missing; returns "oauth-not-configured" when OAuth config missing. Updates tests to assert correct unavailableReason values and prevent Slack connection lookups when configuration incomplete.
API Schema & Validation shared/routes.ts, shared/routes.test.ts	Updates unavailableReason enum from ["unavailable"] to ["tables-not-ready", "oauth-not-configured"]. Adds comprehensive validation tests for new enum values, connected responses, missing fields, and unknown reasons.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~25 minutes

Possibly related PRs

• fix: always show Slack section in notification channels panel #91: Extends earlier getSlackDisplayState refactor by adding "not-ready" state, loading handling, and aligning tests and server schema.
• fix: guard channel tables and restrict Developer page to Power plan #80: Modifies server-side channel-table guards and Slack status behavior with unavailableReason handling.
• fix: Slack integration reliability, security, and architecture improvements #83: End-to-end Slack integration refactor affecting server status responses, client typing, and UI logic across same code paths.

Suggested labels

fix

🚥 Pre-merge checks | ✅ 2 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title 'fix: improve Slack unavailable messaging for end users' accurately summarizes the main objective: distinguishing Slack unavailability reasons and improving user-facing messages. It reflects the core change across the PR.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

• 📝 Generate docstrings (stacked PR)
• 📝 Generate docstrings (commit on current branch)

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch claude/fix-1.1.5-regression-2FG9Y

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}