Skip to content

Skip hidden TitleBar children in visitChildrenForSemantics - #1354

Merged
bdlukaa merged 4 commits into
bdlukaa:masterfrom
melo936:master
Sep 13, 2026
Merged

bdlukaa merged 4 commits into
bdlukaa:masterfrom
melo936:master

Conversation

@melo936

@melo936 melo936 commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Problem

_TitleSubtitleOverflowBox hides the title or subtitle when they no longer fit. Hidden children are skipped in performLayout, paint, and hit testing, but the default visitChildrenForSemantics still walks every child. A hidden child that was marked dirty by the size change is never laid out, so the semantics walk hits the assert. Minimizing a maximized window with a screen reader running triggers the _needsLayout assert.

Special thanks to @Stasium for helping.

Pre-launch Checklist

  • I have updated CHANGELOG.md with my changes
  • I have run "dart format ." on the project
  • I have added/updated relevant documentation

@bdlukaa
bdlukaa merged commit dd4fb51 into bdlukaa:master Sep 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 When window is resized to smaller width, TitleBar shrinks in height

2 participants