#raw_connection proxy to master_connection#44
Open
TripWar wants to merge 1 commit intobdurand:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently SDP returns
nilfor#raw_connectionof the standard adapter. This makes it incompatible with gems like Upsert (https://github.com/seamusabshere/upsert) due to the fact that Upsert tries to grab the raw_connection so it can skip ActiveRecord when generating queries for the database.It makes sense to me that the
#raw_connectionwould return the master connection's raw_connection.The test I wrote is pretty basic, but more than that, the forked gem works with the Upsert gem without any problems.