Skip to content

Week3_Mert#45

Open
Mert1980 wants to merge 91 commits into
be-hacking-hyf:masterfrom
Mert1980:master
Open

Week3_Mert#45
Mert1980 wants to merge 91 commits into
be-hacking-hyf:masterfrom
Mert1980:master

Conversation

@Mert1980
Copy link
Copy Markdown

@Mert1980 Mert1980 commented Oct 4, 2019

I completed Week3 project (DuckDuckGo) and made it live on my forked repo.

I also completed all of the Module Exercises, however FreeCodeCamp sadly allowed me to save the solutions only in JSON format. I hoped that I would be able to convert them into HTML file. Despite every effort I made, I could not convert JSON files into HTML.

@idogrusoz
Copy link
Copy Markdown
Collaborator

@Mert1980 your page looks neat however there are two issues:

  1. The grey section with the search bar and everything should cover the page before scrolling but in your case, the green section is seen.
  2. Unfortunately, your page is not responsive. I would advise to study on this topic and try to use flex or grid.

I want to add that your commitment and motivation are more valuable than your page's responsiveness. You should keep this mindset and the other issues will be solved in time.

@Mert1980
Copy link
Copy Markdown
Author

Mert1980 commented Oct 5, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants