Week3_Mert#45
Open
Mert1980 wants to merge 91 commits into
Open
Conversation
Week2 project links are added to the Readme file
link of pictures are updated
homepage logo created
homepage searchbar and paragraph is created
homepage footer created
second page created
thirdpage created
fourth page of DuckDuckGo created
Fifth Page of DuckDuckGo Created
the paddings of the pages removed, search icon hover function corrected
Week3 project is uploaded
Collaborator
|
@Mert1980 your page looks neat however there are two issues:
I want to add that your commitment and motivation are more valuable than your page's responsiveness. You should keep this mindset and the other issues will be solved in time. |
Author
|
Thank you very much for your review and feedback. I will take your advice
in mind.
Kind regards,
Mert
5 Eki 2019 Cmt 16:37 tarihinde IBRAHIM DOGRUSOZ <notifications@github.com>
şunu yazdı:
… @Mert1980 <https://github.com/Mert1980> your page looks neat however
there are two issues:
1. The grey section with the search bar and everything should cover
the page before scrolling but in your case, the green section is seen.
2. Unfortunately, your page is not responsive. I would advise to study
on this topic and try to use flex or grid.
I want to add that your commitment and motivation are more valuable than
your page's responsiveness. You should keep this mindset and the other
issues will be solved in time.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#45?email_source=notifications&email_token=ANEJLEUS7K6ZTDTHPPDWRNLQNCRDXA5CNFSM4I5T6W2KYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGOEANTUZA#issuecomment-538655332>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ANEJLEV5QXF6VFYDTNELOMLQNCRDXANCNFSM4I5T6W2A>
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I completed Week3 project (DuckDuckGo) and made it live on my forked repo.
I also completed all of the Module Exercises, however FreeCodeCamp sadly allowed me to save the solutions only in JSON format. I hoped that I would be able to convert them into HTML file. Despite every effort I made, I could not convert JSON files into HTML.