feat: Use persistent_term to store patterns in memory#130
Merged
doomspork merged 5 commits intobeam-community:mainfrom Dec 9, 2025
Merged
feat: Use persistent_term to store patterns in memory#130doomspork merged 5 commits intobeam-community:mainfrom
doomspork merged 5 commits intobeam-community:mainfrom
Conversation
doomspork
changed the title
Member
|
This is great @paradox460! Could you take a peek at the failing Credo check? |
Contributor
Author
|
Should be corrected now. I've fixed some additional credo issues that were present in other files |
paradox460
force-pushed
the
persistent_term
branch
from
ee2fc96 to
ea74b01
Compare
Member
|
Thank you @paradox460! |
doomspork
approved these changes
Dec 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The fix introduced in #112 inadvertently caused a performance regression.
Previously, the pattern term was stored in memory, and so reading and parsing against it was fast. The change in #112 made it so every parse request would reload and compile the YAML.
This PR moves the storage into persistent_term, which has performant characteristics, while keeping the same API behavior as before