Issue #4 Broken File Permissions during Usage#5
Open
KexinLu wants to merge 1 commit intobeanworks:masterfrom
Open
Issue #4 Broken File Permissions during Usage#5KexinLu wants to merge 1 commit intobeanworks:masterfrom
KexinLu wants to merge 1 commit intobeanworks:masterfrom
Conversation
Cause: we make a copy of the file then format the copied file, but this file's owner ship and permission are not preserved. Solution: overwrite file content of current file directly
Author
|
please decline this PR, noticed issue while testing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cause: we make a copy of the file then format the copied file, but
this file's owner ship and permission are not preserved.
Solutions tried:
Solution: overwrite file content of current file directly