Skip to content

fix(device-plugin): do not abort plugin start in case no device is found #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkeven merged 1 commit into from
Mar 12, 2026
Merged

fix(device-plugin): do not abort plugin start in case no device is found #16

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cmd/device-plugin/nvidia/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,8 @@ func startPlugins(c *cli.Context, flags []cli.Flag, restarting bool) ([]plugin.I
}

if started == 0 {
klog.Info("No devices found. Waiting indefinitely.")
klog.Info("No devices found. Retrying in 30s...")
return plugins, true, nil
}

return plugins, false, nil
Expand Down
1 change: 1 addition & 0 deletions pkg/device-plugin/nvidiadevice/nvinternal/rm/nvml_manager.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,6 +93,7 @@ func NewNVMLResourceManagers(nvmllib nvml.Interface, config *nvidia.DeviceConfig
nvml: nvmllib,
}
r.rescanInterval = 30 * time.Second
r.lastRescan = time.Now()
rms = append(rms, r)
}

Expand Down
Loading