Skip to content

feat: GC GPU bindings of uninstalled App #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkeven merged 1 commit into from
Nov 27, 2025
Merged

feat: GC GPU bindings of uninstalled App #7

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
46 changes: 46 additions & 0 deletions pkg/scheduler/scheduler.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,46 @@ func (s *Scheduler) CleanupGPUBindingsLoop() {
}
toDelete := make([]string, 0)

existingApps := make(map[string]struct{})
appDiscoveryOK := true
if deps, err := s.kubeClient.AppsV1().Deployments(metav1.NamespaceAll).List(context.Background(),
metav1.ListOptions{LabelSelector: util.AppNameLabelKey}); err != nil {
klog.ErrorS(err, "CleanupGPUBindingsLoop: failed to list Deployments for existing apps")
appDiscoveryOK = false
} else {
for i := range deps.Items {
if app := deps.Items[i].Labels[util.AppNameLabelKey]; app != "" {
existingApps[app] = struct{}{}
}
}
}
if appDiscoveryOK {
if ssets, err := s.kubeClient.AppsV1().StatefulSets(metav1.NamespaceAll).List(context.Background(),
metav1.ListOptions{LabelSelector: util.AppNameLabelKey}); err != nil {
klog.ErrorS(err, "CleanupGPUBindingsLoop: failed to list StatefulSets for existing apps")
appDiscoveryOK = false
} else {
for i := range ssets.Items {
if app := ssets.Items[i].Labels[util.AppNameLabelKey]; app != "" {
existingApps[app] = struct{}{}
}
}
}
}
if appDiscoveryOK {
if pods, err := s.kubeClient.CoreV1().Pods(metav1.NamespaceAll).List(context.Background(),
metav1.ListOptions{LabelSelector: util.AppNameLabelKey}); err != nil {
klog.ErrorS(err, "CleanupGPUBindingsLoop: failed to list Pods for existing apps")
appDiscoveryOK = false
} else {
for i := range pods.Items {
if app := pods.Items[i].Labels[util.AppNameLabelKey]; app != "" {
existingApps[app] = struct{}{}
}
}
}
}

type key struct {
app string
uuid string
Expand All @@ -308,6 +348,12 @@ func (s *Scheduler) CleanupGPUBindingsLoop() {
toDelete = append(toDelete, b.Name)
continue
}
if appDiscoveryOK {
if _, ok := existingApps[b.Spec.AppName]; !ok {
toDelete = append(toDelete, b.Name)
continue
}
}
k := key{app: b.Spec.AppName, uuid: b.Spec.UUID}
group[k] = append(group[k], b)
}
Expand Down