Skip to content

fix: preserve in-progress progress during startup state sync#101

Merged
aby913 merged 2 commits intomainfrom
cursor/-bc-9664e5ee-d4fb-4478-9c12-1b9da09463d7-7a23
Apr 7, 2026
Merged

fix: preserve in-progress progress during startup state sync#101
aby913 merged 2 commits intomainfrom
cursor/-bc-9664e5ee-d4fb-4478-9c12-1b9da09463d7-7a23

Conversation

@aby913
Copy link
Copy Markdown
Member

@aby913 aby913 commented Apr 7, 2026

Summary

  • preserve existing progress only for downloading -> downloading updates when incoming snapshot/state-sync data carries empty progress
  • align CacheManager change detection with write-time merge logic to avoid startup regressions
  • apply the same downloading-only normalization in StateMonitor progress comparison to prevent false app_state_change pushes

Why this scope

The previous broader in-progress-state fallback could retain stale progress in non-downloading states. This update narrows behavior to the only accepted case:

  • keep progress only when both old/new states are downloading and incoming progress is empty
  • do not preserve progress for downloadingCanceling, downloadingCanceled, or other states

Validation

  • go test ./internal/v2/appinfo ./internal/v2/utils
Open in Web Open in Cursor 

cursoragent and others added 2 commits April 7, 2026 08:43
Co-authored-by: aby913 <aby913@users.noreply.github.com>
Co-authored-by: aby913 <aby913@users.noreply.github.com>
@aby913 aby913 changed the title Preserve in-progress progress during startup state sync fix: preserve in-progress progress during startup state sync Apr 7, 2026
@github-actions github-actions bot added the fix label Apr 7, 2026
@aby913 aby913 marked this pull request as ready for review April 7, 2026 09:06
@aby913 aby913 merged commit 3118f97 into main Apr 7, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants