Skip to content

fix: separate param for different local sources#98

Merged
aby913 merged 1 commit intomainfrom
fix/param_local_source
Mar 23, 2026
Merged

fix: separate param for different local sources#98
aby913 merged 1 commit intomainfrom
fix/param_local_source

Conversation

@dkeven
Copy link
Copy Markdown
Member

@dkeven dkeven commented Mar 20, 2026

The current APIs to upload/delete App chart to local sources does not separate different sources, specifically:

  1. In the /app-store/api/v2/apps/upload API handler, a source param is accepted, but is not used in the eventual call to the chartrepo, a hard-coded "upload" is used instead:

    // Add source field
    if err := writer.WriteField("source", "upload"); err != nil {
    return nil, fmt.Errorf("failed to write source field: %w", err)
    }

    This is changed to use the source param.

  2. In the /app-store/api/v2/local-apps/delete API handler, no source param is accepted, and "upload" is also hard coded when requesting the chart repo.
    A source param is added to specify target source when deleting App.

The Dockerfile is changed to make the image smaller.

@github-actions github-actions bot added the fix label Mar 20, 2026
@dkeven dkeven force-pushed the fix/param_local_source branch from ca13135 to 8b99110 Compare March 20, 2026 06:57
@aby913 aby913 merged commit b7e6673 into main Mar 23, 2026
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants