fix: separate param for different local sources#98
Merged
Conversation
ca13135 to
8b99110
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current APIs to upload/delete App chart to local sources does not separate different sources, specifically:
In the
/app-store/api/v2/apps/uploadAPI handler, asourceparam is accepted, but is not used in the eventual call to the chartrepo, a hard-coded"upload"is used instead:market/internal/v2/appinfo/localrepo.go
Lines 270 to 273 in 28d1ec6
This is changed to use the
sourceparam.In the
/app-store/api/v2/local-apps/deleteAPI handler, nosourceparam is accepted, and"upload"is also hard coded when requesting the chart repo.A
sourceparam is added to specify target source when deleting App.The Dockerfile is changed to make the image smaller.